Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2825203003: MD Settings: Remove subpage animation when landing directly on it. (Closed)
Patch Set: feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-basic-page' is the settings page containing the actual settings. 7 * 'settings-basic-page' is the settings page containing the actual settings.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-basic-page', 10 is: 'settings-basic-page',
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 * @private 60 * @private
61 */ 61 */
62 showSecondaryUserBanner_: { 62 showSecondaryUserBanner_: {
63 type: Boolean, 63 type: Boolean,
64 computed: 'computeShowSecondaryUserBanner_(hasExpandedSection_)', 64 computed: 'computeShowSecondaryUserBanner_(hasExpandedSection_)',
65 }, 65 },
66 // </if> 66 // </if>
67 67
68 /** @private {!settings.Route|undefined} */ 68 /** @private {!settings.Route|undefined} */
69 currentRoute_: Object, 69 currentRoute_: Object,
70
71 shouldHideContainer: {
michaelpg 2017/04/27 20:00:20 this should be added by the behavior - is there a
scottchen 2017/05/01 19:25:06 Looks like I don't need it.
72 type: Boolean,
73 notify: true,
74 }
70 }, 75 },
71 76
72 listeners: { 77 listeners: {
73 'subpage-expand': 'onSubpageExpanded_', 78 'subpage-expand': 'onSubpageExpanded_',
74 }, 79 },
75 80
76 /** @override */ 81 /** @override */
77 attached: function() { 82 attached: function() {
78 this.currentRoute_ = settings.getCurrentRoute(); 83 this.currentRoute_ = settings.getCurrentRoute();
79 }, 84 },
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 234
230 /** 235 /**
231 * @param {boolean} opened Whether the menu is expanded. 236 * @param {boolean} opened Whether the menu is expanded.
232 * @return {string} Icon name. 237 * @return {string} Icon name.
233 * @private 238 * @private
234 */ 239 */
235 getArrowIcon_: function(opened) { 240 getArrowIcon_: function(opened) {
236 return opened ? 'cr:arrow-drop-up' : 'cr:arrow-drop-down'; 241 return opened ? 'cr:arrow-drop-up' : 'cr:arrow-drop-down';
237 }, 242 },
238 }); 243 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698