Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2825153002: Update CUPS settings UI to allow USB printers to be added via discovery. (Closed)
Patch Set: Address xdai comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
index 867ac2c9afabe2f0c7f0263862122e8af716bdc9..2971c01f41eb55421a3f8f39705c4553e34ede31 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
@@ -75,7 +75,7 @@
</paper-button>
<paper-button class="action-button" id="addPrinterButton"
disabled="[[!selectedPrinter]]"
- on-tap="switchToConfiguringDialog_">
+ on-tap="switchToManufacturerDialog_">
$i18n{addPrinterButtonText}
</paper-button>
</div>
@@ -317,8 +317,8 @@
<div class="dialog-buttons">
<div> <!-- Left group -->
<paper-button id="manuallyAddPrinterButton" class="secondary-button"
- on-tap="switchToManualAddDialog_">
- $i18n{manuallyAddPrinterButtonText}
+ on-tap="switchToManualAddDialog_" hidden="[[!inManualFlow]]">
xdai1 2017/05/11 00:25:10 Unrelated question: If we want to modify this butt
Carlson 2017/05/11 22:08:58 Good point on both parts. We discussed options of
+ $i18n{back}
</paper-button>
</div>
<div> <!-- Right group -->
@@ -387,7 +387,8 @@
<!-- Manufacturer and Model Dialog -->
<template is="dom-if" if="[[showManufacturerDialog_]]" restamp>
<add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}"
- setup-failed="[[setupFailed]]">
+ selected-printer="{{selectedPrinter}}" setup-failed="[[setupFailed]]"
+ in-manual-flow="[[inManualFlow]]">
</add-printer-manufacturer-model-dialog>
</template>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698