Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2825153002: Update CUPS settings UI to allow USB printers to be added via discovery. (Closed)
Patch Set: Fixup overlooked test revealed by CQ. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/md_select_css.html"> 1 <link rel="import" href="chrome://resources/html/md_select_css.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
7 <link rel="import" href="../i18n_setup.html"> 7 <link rel="import" href="../i18n_setup.html">
8 <link rel="import" href="cups_add_printer_dialog_util.html"> 8 <link rel="import" href="cups_add_printer_dialog_util.html">
9 <link rel="import" href="cups_printers_browser_proxy.html"> 9 <link rel="import" href="cups_printers_browser_proxy.html">
10 <link rel="import" href="../settings_shared_css.html"> 10 <link rel="import" href="../settings_shared_css.html">
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 $i18n{manuallyAddPrinterButtonText} 68 $i18n{manuallyAddPrinterButtonText}
69 </paper-button> 69 </paper-button>
70 </div> 70 </div>
71 <div> <!-- Right group --> 71 <div> <!-- Right group -->
72 <paper-button class="cancel-button secondary-button" 72 <paper-button class="cancel-button secondary-button"
73 on-tap="onCancelTap_"> 73 on-tap="onCancelTap_">
74 $i18n{cancelButtonText} 74 $i18n{cancelButtonText}
75 </paper-button> 75 </paper-button>
76 <paper-button class="action-button" id="addPrinterButton" 76 <paper-button class="action-button" id="addPrinterButton"
77 disabled="[[!selectedPrinter]]" 77 disabled="[[!selectedPrinter]]"
78 on-tap="switchToConfiguringDialog_"> 78 on-tap="switchToManufacturerDialog_">
79 $i18n{addPrinterButtonText} 79 $i18n{addPrinterButtonText}
80 </paper-button> 80 </paper-button>
81 </div> 81 </div>
82 </div> 82 </div>
83 </add-printer-dialog> 83 </add-printer-dialog>
84 </template> 84 </template>
85 </dom-module> 85 </dom-module>
86 86
87 <dom-module id="add-printer-manually-dialog"> 87 <dom-module id="add-printer-manually-dialog">
88 <template> 88 <template>
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 </div> 310 </div>
311 </div> 311 </div>
312 </div> 312 </div>
313 <div class="error-message" hidden="[[!setupFailed]]"> 313 <div class="error-message" hidden="[[!setupFailed]]">
314 Driver not found (exact error message TBD) 314 Driver not found (exact error message TBD)
315 </div> 315 </div>
316 </div> 316 </div>
317 <div class="dialog-buttons"> 317 <div class="dialog-buttons">
318 <div> <!-- Left group --> 318 <div> <!-- Left group -->
319 <paper-button id="manuallyAddPrinterButton" class="secondary-button" 319 <paper-button id="manuallyAddPrinterButton" class="secondary-button"
320 on-tap="switchToManualAddDialog_"> 320 on-tap="switchToPreviousDialog_">
321 $i18n{manuallyAddPrinterButtonText} 321 $i18n{back}
322 </paper-button> 322 </paper-button>
323 </div> 323 </div>
324 <div> <!-- Right group --> 324 <div> <!-- Right group -->
325 <paper-button class="cancel-button secondary-button" 325 <paper-button class="cancel-button secondary-button"
326 on-tap="onCancelTap_"> 326 on-tap="onCancelTap_">
327 $i18n{cancelButtonText} 327 $i18n{cancelButtonText}
328 </paper-button> 328 </paper-button>
329 <paper-button class="action-button" id="addPrinterButton" 329 <paper-button class="action-button" id="addPrinterButton"
330 on-tap="switchToConfiguringDialog_"> 330 on-tap="switchToConfiguringDialog_">
331 $i18n{addPrinterButtonText} 331 $i18n{addPrinterButtonText}
(...skipping 27 matching lines...) Expand all
359 </add-printer-dialog> 359 </add-printer-dialog>
360 </template> 360 </template>
361 </dom-module> 361 </dom-module>
362 362
363 <dom-module id="settings-cups-add-printer-dialog"> 363 <dom-module id="settings-cups-add-printer-dialog">
364 <template> 364 <template>
365 <style include="settings-shared"></style> 365 <style include="settings-shared"></style>
366 366
367 <!-- Printer Discovery Dialog --> 367 <!-- Printer Discovery Dialog -->
368 <template is="dom-if" if="[[showDiscoveryDialog_]]" restamp> 368 <template is="dom-if" if="[[showDiscoveryDialog_]]" restamp>
369 <add-printer-discovery-dialog selected-printer="{{selectedPrinter}}"> 369 <add-printer-discovery-dialog selected-printer="{{newPrinter}}">
370 </add-printer-discovery-dialog> 370 </add-printer-discovery-dialog>
371 </template> 371 </template>
372 372
373 <!-- Manually Add Printer Dialog --> 373 <!-- Manually Add Printer Dialog -->
374 <template is="dom-if" if="[[showManuallyAddDialog_]]" restamp> 374 <template is="dom-if" if="[[showManuallyAddDialog_]]" restamp>
375 <add-printer-manually-dialog new-printer="{{newPrinter}}"> 375 <add-printer-manually-dialog new-printer="{{newPrinter}}">
376 </add-printer-manually-dialog> 376 </add-printer-manually-dialog>
377 </template> 377 </template>
378 378
379 <!-- Configuring Printer Dialog --> 379 <!-- Configuring Printer Dialog -->
380 <template is="dom-if" if="[[showConfiguringDialog_]]" restamp> 380 <template is="dom-if" if="[[showConfiguringDialog_]]" restamp>
381 <add-printer-configuring-dialog 381 <add-printer-configuring-dialog
382 printer-name="[[getConfiguringPrinterName_()]]" 382 printer-name="[[newPrinter.printerName]]"
383 dialog-title="[[configuringDialogTitle]]"> 383 dialog-title="[[configuringDialogTitle]]">
384 </add-printer-configuring-dialog> 384 </add-printer-configuring-dialog>
385 </template> 385 </template>
386 386
387 <!-- Manufacturer and Model Dialog --> 387 <!-- Manufacturer and Model Dialog -->
388 <template is="dom-if" if="[[showManufacturerDialog_]]" restamp> 388 <template is="dom-if" if="[[showManufacturerDialog_]]" restamp>
389 <add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}" 389 <add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}"
390 setup-failed="[[setupFailed]]"> 390 previous-dialog="[[previousDialog]]" setup-failed="[[setupFailed]]">
391 </add-printer-manufacturer-model-dialog> 391 </add-printer-manufacturer-model-dialog>
392 </template> 392 </template>
393 393
394 </template> 394 </template>
395 <script src="cups_add_printer_dialog.js"></script> 395 <script src="cups_add_printer_dialog.js"></script>
396 </dom-module> 396 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698