Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: ios/chrome/browser/payments/credit_card_edit_view_controller.mm

Issue 2825143002: [Payment Request] Accepted credit card type icons in the credit card editor (Closed)
Patch Set: Addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/credit_card_edit_view_controller.mm
diff --git a/ios/chrome/browser/payments/credit_card_edit_view_controller.mm b/ios/chrome/browser/payments/credit_card_edit_view_controller.mm
index 3233778a7b86f733f9e9fc34e390437fa74225d4..89e15e8bcfb81732aca68c852451c6a3dab094cc 100644
--- a/ios/chrome/browser/payments/credit_card_edit_view_controller.mm
+++ b/ios/chrome/browser/payments/credit_card_edit_view_controller.mm
@@ -32,13 +32,15 @@ NSString* const kCreditCardEditCollectionViewId =
@"kCreditCardEditCollectionViewId";
typedef NS_ENUM(NSInteger, SectionIdentifier) {
- SectionIdentifierCardSummary = kSectionIdentifierEnumStart,
+ SectionIdentifierAcceptedMethods = kSectionIdentifierEnumStart,
+ SectionIdentifierCardSummary,
SectionIdentifierBillingAddress,
SectionIdentifierSaveCard,
};
typedef NS_ENUM(NSInteger, ItemType) {
- ItemTypeCardSummary = kItemTypeEnumStart,
+ ItemTypeAcceptedMethods = kItemTypeEnumStart,
+ ItemTypeCardSummary,
ItemTypeBillingAddress,
ItemTypeSaveCard,
};
@@ -171,6 +173,16 @@ typedef NS_ENUM(NSInteger, ItemType) {
[model addItem:serverCardSummaryItem
toSectionWithIdentifier:SectionIdentifierCardSummary];
}
+
+ // Accepted payment methods section.
+ CollectionViewItem* acceptedMethodsItem =
+ [_dataSource acceptedPaymentMethodsItem];
+ if (acceptedMethodsItem) {
+ [model addSectionWithIdentifier:SectionIdentifierAcceptedMethods];
+ acceptedMethodsItem.type = ItemTypeAcceptedMethods;
+ [model addItem:acceptedMethodsItem
+ toSectionWithIdentifier:SectionIdentifierAcceptedMethods];
+ }
}
- (void)loadFooterItems {
@@ -285,6 +297,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
CollectionViewItem* item =
[self.collectionViewModel itemAtIndexPath:indexPath];
switch (item.type) {
+ case ItemTypeAcceptedMethods:
case ItemTypeCardSummary:
case ItemTypeSaveCard:
break;
@@ -306,6 +319,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
switch (item.type) {
case ItemTypeBillingAddress:
return MDCCellDefaultOneLineHeight;
+ case ItemTypeAcceptedMethods:
case ItemTypeCardSummary:
case ItemTypeSaveCard:
return [MDCCollectionViewCell
@@ -321,6 +335,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
hidesInkViewAtIndexPath:(NSIndexPath*)indexPath {
NSInteger type = [self.collectionViewModel itemTypeForIndexPath:indexPath];
switch (type) {
+ case ItemTypeAcceptedMethods:
case ItemTypeCardSummary:
case ItemTypeSaveCard:
return YES;
@@ -330,6 +345,18 @@ typedef NS_ENUM(NSInteger, ItemType) {
}
}
+- (BOOL)collectionView:(UICollectionView*)collectionView
+ shouldHideItemBackgroundAtIndexPath:(NSIndexPath*)indexPath {
+ NSInteger type = [self.collectionViewModel itemTypeForIndexPath:indexPath];
+ switch (type) {
+ case ItemTypeAcceptedMethods:
+ return YES;
+ default:
+ return [super collectionView:collectionView
+ shouldHideItemBackgroundAtIndexPath:indexPath];
+ }
+}
+
#pragma mark Switch Actions
- (void)saveCardSwitchToggled:(UISwitch*)sender {

Powered by Google App Engine
This is Rietveld 408576698