[Payment Request] Accepted credit card type icons in the credit card editor

ios/chrome/browser/payments/credit_card_edit_view_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_PAYMENTS_CREDIT_CARD_EDIT_VIEW_CONTROLLER_H_
 #define IOS_CHROME_BROWSER_PAYMENTS_CREDIT_CARD_EDIT_VIEW_CONTROLLER_H_
 
 #import "ios/chrome/browser/payments/payment_request_edit_view_controller.h"
 
 @class EditorField;
 @class CreditCardEditViewController;
 
 typedef NS_ENUM(NSInteger, CreditCardEditViewControllerState) {
   // The view controller is used to create a new credit card.
   CreditCardEditViewControllerStateCreate,
   // The view controller is used to edit a credit card.
   CreditCardEditViewControllerStateEdit,
 };
 
 // Data source protocol for CreditCardEditViewController.
 @protocol CreditCardEditViewControllerDataSource<

[lpromero, 2017/04/20 16:59:52]

It might be time to move this into its own _data_source.h file, in a follow-up
CL.

[Moe, 2017/04/21 14:14:14]

Acknowledged.

     PaymentRequestEditViewControllerDataSource>
 
 // Returns an item that identifies the server card being edited. Returns nil for
 // local cards or when a card is being created.
 - (CollectionViewItem*)serverCardSummaryItem;
 
+// Returns an item that displays a list of payment method type icons for the
+// accepted payment methods. Returns nil if a server card is being edited.

[lpromero, 2017/04/20 16:59:52]

The notion of server card seems to me more like a detail from your implementor
instead of this data source protocol, no? This could also apply to the other
comments. I am fine as is.

[Moe, 2017/04/21 14:14:14]

Agreed. Done.

+- (CollectionViewItem*)acceptedPaymentMethodsItem;
+
 // Returns the billing address label from an autofill profile with the given
 // guid. Returns nil if the profile does not have an address.
 - (NSString*)billingAddressLabelForProfileWithGUID:(NSString*)profileGUID;
 
 // Returns the credit card type icon corresponding to |cardNumber|.
 - (UIImage*)cardTypeIconFromCardNumber:(NSString*)cardNumber;
 
 @end
 
 // Delegate protocol for CreditCardEditViewController.
@@ skipping 35 matching lines @@
 @property(nonatomic, assign) CreditCardEditViewControllerState state;
 
 - (instancetype)init NS_DESIGNATED_INITIALIZER;
 
 - (instancetype)initWithStyle:(CollectionViewControllerStyle)style
     NS_UNAVAILABLE;
 
 @end
 
 #endif  // IOS_CHROME_BROWSER_PAYMENTS_CREDIT_CARD_EDIT_VIEW_CONTROLLER_H_