Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html

Issue 2825133003: [css-grid] Ignore collapsed tracks on content-distribution alignment (Closed)
Patch Set: Fixed error in the test expectations Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-004.html b/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html
similarity index 63%
copy from third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-004.html
copy to third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html
index 2959fb5157900493c287fcabd9fbf3d548a96f8e..3b9a2082c4ef5bda57ecd623497ae7d9a7d051a5 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-004.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html
@@ -1,6 +1,6 @@
<!DOCTYPE html>
<meta charset="utf-8">
-<title>CSS Grid Layout Test: Content Distribution 'stretch' with collapsed tracks</title>
+<title>CSS Grid Layout Test: Content Distribution 'stretch' and gaps with collapsed tracks on 3x3 grid</title>
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="help" href="https://drafts.csswg.org/css-align-3/#content-distribution">
<link rel="help" href="https://drafts.csswg.org/css-grid/#collapsed-track">
@@ -17,8 +17,8 @@
.block > div {
position: absolute;
background: red;
- width: 100px;
- height: 100px;
+ width: 60px;
+ height: 60px;
}
.grid {
z-index: 1;
@@ -27,6 +27,8 @@
height: 200px;
grid-template-columns: repeat(auto-fit, minmax(25px, auto));
grid-template-rows: repeat(auto-fit, minmax(25px, auto));
+ grid-row-gap: 10px;
+ grid-column-gap: 10px;
align-content: stretch;
justify-content: stretch;
}
@@ -34,10 +36,14 @@
</style>
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div class="block">
- <div style="top: 0px; left: 0px;"></div>
- <div style="top: 100px; left: 100px;"></div>
+ <div style="top: 0px; left: 70px;"></div>
+ <div style="top: 0px; left: 140px;"></div>
+ <div style="top: 70px; left: 0px;"></div>
+ <div style="top: 140px; left: 0px;"></div>
</div>
<div class="grid">
- <div style="grid-row: 1; grid-column: 1;"></div>
- <div style="grid-row: 3; grid-column: 6;"></div>
+ <div class="item" style="grid-row: 1; grid-column: 3;"></div>
+ <div class="item" style="grid-row: 1; grid-column: 4;"></div>
+ <div class="item" style="grid-row: 3; grid-column: 1;"></div>
+ <div class="item" style="grid-row: 4; grid-column: 1;"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698