Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: ios/chrome/browser/passwords/resources/password_controller.js

Issue 2825123003: Remove hasPasswordField from the public __gCrWeb API. (Closed)
Patch Set: Fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/passwords/password_controller_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/passwords/resources/password_controller.js
diff --git a/ios/chrome/browser/passwords/resources/password_controller.js b/ios/chrome/browser/passwords/resources/password_controller.js
index c04af67cdf8314a4b9c6a35861f8be75a50409cd..506896dc17f6693fb91dfe313ca2f69e01bee82f 100644
--- a/ios/chrome/browser/passwords/resources/password_controller.js
+++ b/ios/chrome/browser/passwords/resources/password_controller.js
@@ -34,20 +34,6 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
return __gCrWeb.stringify(formDataList);
};
- /**
- * Returns true if the top window or any frames inside contain an input field
- * of type 'password'. This method is only used for unit tests and are only
- * kept for legacy reasons. Prefer to use the private
- * {@code hasPasswordField_} within this file.
- * @return {boolean} Whether a password field exists.
- *
- * TODO(crbug.com/614092): investigate if this method can be completely
- * removed from the gCrWeb public interface.
- */
- __gCrWeb['hasPasswordField'] = function() {
- return hasPasswordField_(window);
- };
-
/** Returns true if the supplied window or any frames inside contain an input
* field of type 'password'.
* @private
« no previous file with comments | « ios/chrome/browser/passwords/password_controller_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698