Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/crashpad/crashpad/util/mach/mach_message_server.h

Issue 2825103002: Update Crashpad to b8aaa22905308cc400f880006a84dddac834bd6b (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/mach/mach_message_server.h
diff --git a/third_party/crashpad/crashpad/util/mach/mach_message_server.h b/third_party/crashpad/crashpad/util/mach/mach_message_server.h
index 9793560e532b000e3d846d90db7c7f6a5ae1bcd0..5e96c4cef365feac16aa4a2dd13fac8fcb78470e 100644
--- a/third_party/crashpad/crashpad/util/mach/mach_message_server.h
+++ b/third_party/crashpad/crashpad/util/mach/mach_message_server.h
@@ -162,7 +162,11 @@ class MachMessageServer {
//! timeout_ms is not #kMachMessageTimeoutWaitIndefinitely). This function
//! has no successful return value when \a persistent is #kPersistent and
//! \a timeout_ms is #kMachMessageTimeoutWaitIndefinitely. On failure,
- //! returns a value identifying the nature of the error.
+ //! returns a value identifying the nature of the error. A request
+ //! received with a reply port that is (or becomes) a dead name before the
+ //! reply is sent will result in `MACH_SEND_INVALID_DEST` as a return
+ //! value, which may or may not be considered an error from the caller’s
+ //! perspective.
static mach_msg_return_t Run(Interface* interface,
mach_port_t receive_port,
mach_msg_options_t options,

Powered by Google App Engine
This is Rietveld 408576698