Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2825071: [gcc] Remove few changes from machine-independent part. (Closed)

Created:
10 years, 5 months ago by eaeltsin
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
ssh://git@chromiumos-git/nacl-toolchain.git
Visibility:
Public.

Description

[gcc] Remove few changes from machine-independent part. This change restores explow.c and reload.c back to their original state. This change can affect the performance, as it may limit the number of cases when lea instruction is generated. However, the change is the "right thing" to do. Lea problems, if any, should be solved in i386-specific code.

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M gcc/gcc/config/i386/i386.c View 1 chunk +3 lines, -0 lines 0 comments Download
M gcc/gcc/explow.c View 1 chunk +1 line, -7 lines 0 comments Download
M gcc/gcc/reload.c View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eaeltsin
10 years, 5 months ago (2010-07-27 15:03:37 UTC) #1
pasko-google - do not use
LGTM Generally, this is the right thing to do. Though in practice performance implications are ...
10 years, 5 months ago (2010-07-27 21:54:52 UTC) #2
eaeltsin
10 years, 4 months ago (2010-07-29 08:53:21 UTC) #3
I'll submit this. If performance degrades, I'll investigate ASAP.

http://codereview.chromium.org/2825071/diff/1/4
File gcc/gcc/reload.c (left):

http://codereview.chromium.org/2825071/diff/1/4#oldcode4696
gcc/gcc/reload.c:4696: reg_equiv_constant[regno]
On 2010/07/27 21:54:52, pasko wrote:
> I didn't change this code. Changing something in the core of reload.c is
indeed
> hardcore.

This code was different from the original. I'm not saying you did this - in fact
it doesn't matter who did this :-)

Powered by Google App Engine
This is Rietveld 408576698