Issue 2825059: Fix an unitialized read in a unit test to appease valgrind

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2825059: Fix an unitialized read in a unit test to appease valgrind (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Nico

Modified:
4 years ago

Reviewers:
Victoria, vrk (LEFT CHROMIUM), Alpha Left Google, Paweł Hajdan Jr.

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko, fbarchard, Alpha Left Google, awong (On leave), Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (very slow to review)

Visibility:
Public.

Description

Fix an unitialized read in a unit test to appease valgrind See http://codereview.chromium.org/2908003 for some backstory. BUG=none TEST=Webkit Mac memory bot goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52988

Patch Set 1 #

Patch Set 2 : fix problem instead of suppressing it #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -25 lines)			Patch
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -20 lines	0 comments	Download
M	webkit/glue/media/buffered_data_source.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/media/buffered_data_source_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: linux_valgrind linux mac mac_valgrind win

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

OK A more detailed commit message would be a plus.

4 years, 10 months ago (2010-07-20 00:46:08 UTC) #2

Nico

This isn't actually a valgrind bug (this would've surprised me for something this basic). I ...

4 years, 10 months ago (2010-07-20 01:08:04 UTC) #3

Victoria

4 years, 10 months ago (2010-07-20 18:07:23 UTC) #6

LGTM

Thanks for catching this!

On 2010/07/20 01:22:10, Paweł Hajdan Jr. wrote:
> LGTM.

Expand Messages | Collapse Messages