Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2825055: Step 1 in getting rid of duplicate warning in make build. (Closed)

Created:
10 years, 7 months ago by tony
Modified:
9 years, 9 months ago
Reviewers:
tkent, Evan Martin
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Step 1 in getting rid of duplicate warning in make build. The plan is to make a target just for the copy and have both test_shell and DRT use it. This change creates the target and has test_shell use it. Step 2 is to have DRT to use it. Step 3 is to roll deps so we don't get the warning anymore. BUG=47256 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52869

Patch Set 1 #

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -30 lines) Patch
M webkit/tools/npapi_layout_test_plugin/npapi_layout_test_plugin.gypi View 1 1 chunk +33 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 5 chunks +1 line, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
10 years, 7 months ago (2010-07-17 01:42:06 UTC) #1
Evan Martin
10 years, 7 months ago (2010-07-17 01:46:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698