Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2825053002: Add typedef AST node boilerplate. (Closed)

Created:
3 years, 8 months ago by asgerf
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add typedef AST node boilerplate. This adds the Typedef and TypedefType to the kernel AST, with the relevant boilerplate. Typedefs are not implemented in frontend or backend. R=ahe@google.com, kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/d1c3ee4b35227cb6926f03479a34f82774523773 Committed: https://github.com/dart-lang/sdk/commit/ac40d0bb8e98f981780344fe365ebee2e401319b

Patch Set 1 #

Patch Set 2 : Add annotations to Typedef #

Patch Set 3 : Revert+Unrevert #

Patch Set 4 : Update FastaVerifyingVisitor to work with the changes in VerifyingVisitor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -8 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/verifier.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/ast.dart View 1 9 chunks +145 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 2 4 chunks +31 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/tag.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/canonical_name.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 6 chunks +31 lines, -0 lines 0 comments Download
M pkg/kernel/lib/transformations/reify/transformation/remove_generics.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/kernel/lib/transformations/treeshaker.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/kernel/lib/type_algebra.dart View 3 chunks +20 lines, -0 lines 0 comments Download
M pkg/kernel/lib/type_environment.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/kernel/lib/verifier.dart View 9 chunks +65 lines, -6 lines 0 comments Download
M pkg/kernel/lib/visitor.dart View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M pkg/kernel/test/type_parser.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/kernel/test/typedef_unalias_test.dart View 1 chunk +68 lines, -0 lines 0 comments Download
M pkg/kernel/test/verify_test.dart View 1 chunk +165 lines, -0 lines 0 comments Download
M runtime/vm/kernel.h View 1 2 9 chunks +72 lines, -1 line 0 comments Download
M runtime/vm/kernel.cc View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M runtime/vm/kernel_binary.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 1 2 5 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
asgerf
3 years, 8 months ago (2017-04-18 14:19:27 UTC) #2
ahe
Dart code LGTM!
3 years, 8 months ago (2017-04-18 15:32:04 UTC) #3
Kevin Millikin (Google)
LGTM.
3 years, 8 months ago (2017-04-19 13:26:38 UTC) #4
asgerf
Committed patchset #2 (id:20001) manually as d1c3ee4b35227cb6926f03479a34f82774523773 (presubmit successful).
3 years, 7 months ago (2017-04-28 10:39:28 UTC) #6
asgerf
Committed patchset #4 (id:60001) manually as ac40d0bb8e98f981780344fe365ebee2e401319b (presubmit successful).
3 years, 7 months ago (2017-04-28 11:26:54 UTC) #8
ahe
3 years, 7 months ago (2017-04-28 11:28:55 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698