Issue 2825043002: VM: Prohibit reload when throwing or processing language errors.

Issue 2825043002: VM: Prohibit reload when throwing or processing language errors. (Closed)

Created:
3 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
3 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Prohibit reload when throwing or processing language errors. This fixes flaky crashes on negative tests in stress reload mode: when we attempt to reload an isolate while throwing/formatting compile time error. Fixes https://github.com/dart-lang/sdk/issues/27835 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8f563f2c3292c01416be0233c6fdeb07d346109d

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	runtime/vm/exceptions.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Vyacheslav Egorov (Google)

3 years, 8 months ago (2017-04-18 16:51:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8f563f2c3292c01416be0233c6fdeb07d346109d (presubmit successful).