Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: net/cert/signed_certificate_timestamp.h

Issue 2824983002: Rename net::ct::LogEntry to SignedEntryData and clarify the comment. (Closed)
Patch Set: sort forward decls Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/multi_log_ct_verifier.cc ('k') | net/cert/signed_certificate_timestamp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/signed_certificate_timestamp.h
diff --git a/net/cert/signed_certificate_timestamp.h b/net/cert/signed_certificate_timestamp.h
index 96eded2c54bd95abf7738f275c0fa9904129e513..a23b70810b55fc30ed99a8f06cb38d02c3d55a69 100644
--- a/net/cert/signed_certificate_timestamp.h
+++ b/net/cert/signed_certificate_timestamp.h
@@ -24,16 +24,29 @@ namespace net {
// Structures related to Certificate Transparency (RFC6962).
namespace ct {
-// LogEntry struct in RFC 6962, Section 3.1
-struct NET_EXPORT LogEntry {
+// Contains the data necessary to reconstruct the signed_entry of a
+// SignedCertificateTimestamp, from RFC 6962, Section 3.2.
+//
+// All the data necessary to validate a SignedCertificateTimestamp is present
+// within the SignedCertificateTimestamp, except for the signature_type,
+// entry_type, and the actual entry. The only supported signature_type at
+// present is certificate_timestamp. The entry_type is implicit from the
+// context in which it is received (those in the X.509 extension are
+// precert_entry, all others are x509_entry). The signed_entry itself is
+// reconstructed from the certificate being verified, or from the corresponding
+// precertificate.
+//
+// The SignedEntryData contains this reconstructed data, and can be used to
+// either generate or verify the signature in SCTs.
+struct NET_EXPORT SignedEntryData {
// LogEntryType enum in RFC 6962, Section 3.1
enum Type {
LOG_ENTRY_TYPE_X509 = 0,
LOG_ENTRY_TYPE_PRECERT = 1
};
- LogEntry();
- ~LogEntry();
+ SignedEntryData();
+ ~SignedEntryData();
void Reset();
Type type;
« no previous file with comments | « net/cert/multi_log_ct_verifier.cc ('k') | net/cert/signed_certificate_timestamp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698