Rename net::ct::LogEntry to SignedEntryData and clarify the comment.

net/cert/multi_log_ct_verifier.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/multi_log_ct_verifier.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 79 matching lines @@
   DCHECK(cert);
   DCHECK(output_scts);
 
   output_scts->clear();
 
   std::string embedded_scts;
   if (!cert->GetIntermediateCertificates().empty() &&
       ct::ExtractEmbeddedSCTList(
           cert->os_cert_handle(),
           &embedded_scts)) {
-    ct::LogEntry precert_entry;
+    ct::SignedEntryData precert_entry;
 
-    if (ct::GetPrecertLogEntry(cert->os_cert_handle(),
-                               cert->GetIntermediateCertificates().front(),
-                               &precert_entry)) {
+    if (ct::GetPrecertSignedEntry(cert->os_cert_handle(),
+                                  cert->GetIntermediateCertificates().front(),
+                                  &precert_entry)) {
       VerifySCTs(embedded_scts, precert_entry,
                  ct::SignedCertificateTimestamp::SCT_EMBEDDED, cert,
                  output_scts);
     }
   }
 
   std::string sct_list_from_ocsp;
   if (!stapled_ocsp_response.empty() &&
       !cert->GetIntermediateCertificates().empty()) {
     ct::ExtractSCTListFromOCSPResponse(
         cert->GetIntermediateCertificates().front(), cert->serial_number(),
         stapled_ocsp_response, &sct_list_from_ocsp);
   }
 
   // Log to Net Log, after extracting SCTs but before possibly failing on
   // X.509 entry creation.
   NetLogParametersCallback net_log_callback =
       base::Bind(&NetLogRawSignedCertificateTimestampCallback, embedded_scts,
                  sct_list_from_ocsp, sct_list_from_tls_extension);
 
   net_log.AddEvent(NetLogEventType::SIGNED_CERTIFICATE_TIMESTAMPS_RECEIVED,
                    net_log_callback);
 
-  ct::LogEntry x509_entry;
-  if (ct::GetX509LogEntry(cert->os_cert_handle(), &x509_entry)) {
+  ct::SignedEntryData x509_entry;
+  if (ct::GetX509SignedEntry(cert->os_cert_handle(), &x509_entry)) {
     VerifySCTs(sct_list_from_ocsp, x509_entry,
                ct::SignedCertificateTimestamp::SCT_FROM_OCSP_RESPONSE, cert,
                output_scts);
 
     VerifySCTs(sct_list_from_tls_extension, x509_entry,
                ct::SignedCertificateTimestamp::SCT_FROM_TLS_EXTENSION, cert,
                output_scts);
   }
 
   NetLogParametersCallback net_log_checked_callback =
       base::Bind(&NetLogSignedCertificateTimestampCallback, output_scts);
 
   net_log.AddEvent(NetLogEventType::SIGNED_CERTIFICATE_TIMESTAMPS_CHECKED,
                    net_log_checked_callback);
 
   LogNumSCTsToUMA(*output_scts);
 }
 
 void MultiLogCTVerifier::VerifySCTs(
     base::StringPiece encoded_sct_list,
-    const ct::LogEntry& expected_entry,
+    const ct::SignedEntryData& expected_entry,
     ct::SignedCertificateTimestamp::Origin origin,
     X509Certificate* cert,
     SignedCertificateTimestampAndStatusList* output_scts) {
   if (logs_.empty())
     return;
 
   std::vector<base::StringPiece> sct_list;
 
   if (!ct::DecodeSCTList(encoded_sct_list, &sct_list))
     return;
 
   for (std::vector<base::StringPiece>::const_iterator it = sct_list.begin();
        it != sct_list.end(); ++it) {
     base::StringPiece encoded_sct(*it);
     LogSCTOriginToUMA(origin);
 
     scoped_refptr<ct::SignedCertificateTimestamp> decoded_sct;
     if (!DecodeSignedCertificateTimestamp(&encoded_sct, &decoded_sct)) {
       LogSCTStatusToUMA(ct::SCT_STATUS_NONE);
       continue;
     }
     decoded_sct->origin = origin;
 
     VerifySingleSCT(decoded_sct, expected_entry, cert, output_scts);
   }
 }
 
 bool MultiLogCTVerifier::VerifySingleSCT(
     scoped_refptr<ct::SignedCertificateTimestamp> sct,
-    const ct::LogEntry& expected_entry,
+    const ct::SignedEntryData& expected_entry,
     X509Certificate* cert,
     SignedCertificateTimestampAndStatusList* output_scts) {
   // Assume this SCT is untrusted until proven otherwise.
   const auto& it = logs_.find(sct->log_id);
   if (it == logs_.end()) {
     DVLOG(1) << "SCT does not match any known log.";
     AddSCTAndLogStatus(sct, ct::SCT_STATUS_LOG_UNKNOWN, output_scts);
     return false;
   }
 
@@ skipping 12 matching lines @@
     return false;
   }
 
   AddSCTAndLogStatus(sct, ct::SCT_STATUS_OK, output_scts);
   if (observer_)
     observer_->OnSCTVerified(cert, sct.get());
   return true;
 }
 
 } // namespace net