Rename net::ct::LogEntry to SignedEntryData and clarify the comment.

net/cert/ct_objects_extractor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_objects_extractor.h"
 
 #include "base/files/file_path.h"
 #include "net/cert/ct_log_verifier.h"
 #include "net/cert/ct_serialization.h"
 #include "net/cert/signed_certificate_timestamp.h"
@@ skipping 54 matching lines @@
   EXPECT_EQ(sct->version, SignedCertificateTimestamp::V1);
   EXPECT_EQ(ct::GetTestPublicKeyId(), sct->log_id);
 
   base::Time expected_timestamp =
       base::Time::UnixEpoch() +
       base::TimeDelta::FromMilliseconds(1365181456275);
   EXPECT_EQ(expected_timestamp, sct->timestamp);
 }
 
 TEST_F(CTObjectsExtractorTest, ExtractPrecert) {
-  LogEntry entry;
-  ASSERT_TRUE(GetPrecertLogEntry(precert_chain_[0]->os_cert_handle(),
-                                 precert_chain_[1]->os_cert_handle(),
-                                 &entry));
+  SignedEntryData entry;
+  ASSERT_TRUE(GetPrecertSignedEntry(precert_chain_[0]->os_cert_handle(),
+                                    precert_chain_[1]->os_cert_handle(),
+                                    &entry));
 
-  ASSERT_EQ(ct::LogEntry::LOG_ENTRY_TYPE_PRECERT, entry.type);
+  ASSERT_EQ(ct::SignedEntryData::LOG_ENTRY_TYPE_PRECERT, entry.type);
   // Should have empty leaf cert for this log entry type.
   ASSERT_TRUE(entry.leaf_certificate.empty());
   // Compare hash values of issuer spki.
   SHA256HashValue expected_issuer_key_hash;
   memcpy(expected_issuer_key_hash.data, GetDefaultIssuerKeyHash().data(), 32);
   ASSERT_EQ(expected_issuer_key_hash, entry.issuer_key_hash);
 }
 
 TEST_F(CTObjectsExtractorTest, ExtractOrdinaryX509Cert) {
-  LogEntry entry;
-  ASSERT_TRUE(GetX509LogEntry(test_cert_->os_cert_handle(), &entry));
+  SignedEntryData entry;
+  ASSERT_TRUE(GetX509SignedEntry(test_cert_->os_cert_handle(), &entry));
 
-  ASSERT_EQ(ct::LogEntry::LOG_ENTRY_TYPE_X509, entry.type);
+  ASSERT_EQ(ct::SignedEntryData::LOG_ENTRY_TYPE_X509, entry.type);
   // Should have empty tbs_certificate for this log entry type.
   ASSERT_TRUE(entry.tbs_certificate.empty());
   // Length of leaf_certificate should be 718, see the CT Serialization tests.
   ASSERT_EQ(718U, entry.leaf_certificate.size());
 }
 
 // Test that the embedded SCT verifies
 TEST_F(CTObjectsExtractorTest, ExtractedSCTVerifies) {
   scoped_refptr<ct::SignedCertificateTimestamp> sct(
       new ct::SignedCertificateTimestamp());
   ExtractEmbeddedSCT(precert_chain_[0], &sct);
 
-  LogEntry entry;
-  ASSERT_TRUE(GetPrecertLogEntry(precert_chain_[0]->os_cert_handle(),
-                                 precert_chain_[1]->os_cert_handle(),
-                                 &entry));
+  SignedEntryData entry;
+  ASSERT_TRUE(GetPrecertSignedEntry(precert_chain_[0]->os_cert_handle(),
+                                    precert_chain_[1]->os_cert_handle(),
+                                    &entry));
 
   EXPECT_TRUE(log_->Verify(entry, *sct.get()));
 }
 
-// Test that an externally-provided SCT verifies over the LogEntry
+// Test that an externally-provided SCT verifies over the SignedEntryData
 // of a regular X.509 Certificate
 TEST_F(CTObjectsExtractorTest, ComplementarySCTVerifies) {
   scoped_refptr<ct::SignedCertificateTimestamp> sct(
       new ct::SignedCertificateTimestamp());
   GetX509CertSCT(&sct);
 
-  LogEntry entry;
-  ASSERT_TRUE(GetX509LogEntry(test_cert_->os_cert_handle(), &entry));
+  SignedEntryData entry;
+  ASSERT_TRUE(GetX509SignedEntry(test_cert_->os_cert_handle(), &entry));
 
   EXPECT_TRUE(log_->Verify(entry, *sct.get()));
 }
 
 // Test that the extractor can parse OCSP responses.
 TEST_F(CTObjectsExtractorTest, ExtractSCTListFromOCSPResponse) {
   std::string der_subject_cert(ct::GetDerEncodedFakeOCSPResponseCert());
   scoped_refptr<X509Certificate> subject_cert =
       X509Certificate::CreateFromBytes(der_subject_cert.data(),
                                        der_subject_cert.length());
@@ skipping 44 matching lines @@
   std::string extracted_sct_list;
   // Use test_cert_ for issuer - it is not the correct issuer of |subject_cert|.
   EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(
       test_cert_->os_cert_handle(), subject_cert->serial_number(),
       ocsp_response, &extracted_sct_list));
 }
 
 }  // namespace ct
 
 }  // namespace net