third_party/WebKit/Source/core/style/StyleSurroundData.cpp - Issue 2824973002: Split StyleSurroundData::margin into four individual Lengths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleSurroundData.cpp

Issue 2824973002: Split StyleSurroundData::margin into four individual Lengths. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/style/ComputedStyle.h ('K') | « third_party/WebKit/Source/core/style/StyleSurroundData.h ('k') | third_party/WebKit/Source/platform/LengthBox.h » ('j') | third_party/WebKit/Source/platform/LengthBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleSurroundData.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleSurroundData.cpp b/third_party/WebKit/Source/core/style/StyleSurroundData.cpp

index 3489aea0e040983e48611e2b455a6179bf956ec8..18e1cb3c5a2240e546b4c5a03ec1c07f5053afb5 100644

--- a/third_party/WebKit/Source/core/style/StyleSurroundData.cpp

+++ b/third_party/WebKit/Source/core/style/StyleSurroundData.cpp

@@ -23,7 +23,12 @@

namespace blink {

-StyleSurroundData::StyleSurroundData() : margin_(kFixed), padding_(kFixed) {}

+StyleSurroundData::StyleSurroundData()

+ : margin_left_(kFixed),

+ margin_right_(kFixed),

+ margin_top_(kFixed),

+ margin_bottom_(kFixed),

+ padding_(kFixed) {}

StyleSurroundData::StyleSurroundData(const StyleSurroundData& o)

: RefCounted<StyleSurroundData>(),

@@ -31,14 +36,19 @@ StyleSurroundData::StyleSurroundData(const StyleSurroundData& o)

right_(o.right_),

top_(o.top_),

bottom_(o.bottom_),

- margin_(o.margin_),

+ margin_left_(o.margin_left_),

+ margin_right_(o.margin_right_),

+ margin_top_(o.margin_top_),

+ margin_bottom_(o.margin_bottom_),

padding_(o.padding_),

border_(o.border_) {}

bool StyleSurroundData::operator==(const StyleSurroundData& o) const {

return left_ == o.left_ && right_ == o.right_ && top_ == o.top_ &&

- bottom_ == o.bottom_ && margin_ == o.margin_ &&

- padding_ == o.padding_ && border_ == o.border_;

+ bottom_ == o.bottom_ && margin_left_ == o.margin_left_ &&

+ margin_right_ == o.margin_right_ && margin_top_ == o.margin_top_ &&

+ margin_bottom_ == o.margin_bottom_ && padding_ == o.padding_ &&

+ border_ == o.border_;

alancutter (OOO until 2018) 2017/04/19 07:01:21 Nit: Let's group related properties with parenthes

shend 2017/04/19 07:19:24 Done.

}

} // namespace blink