Split StyleSurroundData::margin into four individual Lengths.

third_party/WebKit/Source/core/style/ComputedStyle.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 1076 matching lines @@
     return static_cast<EIsolation>(rare_non_inherited_data_->isolation_);
   }
   void SetIsolation(EIsolation v) {
     rare_non_inherited_data_.Access()->isolation_ = v;
   }
 
   // Margin properties.
   static Length InitialMargin() { return Length(kFixed); }
 
   // margin-top
-  const Length& MarginTop() const { return surround_->margin_.Top(); }
-  void SetMarginTop(const Length& v) { SET_VAR(surround_, margin_.top_, v); }
+  const Length& MarginTop() const { return surround_->margin_top_; }
+  void SetMarginTop(const Length& v) { SET_VAR(surround_, margin_top_, v); }
 
   // margin-bottom
-  const Length& MarginBottom() const { return surround_->margin_.Bottom(); }
+  const Length& MarginBottom() const { return surround_->margin_bottom_; }
   void SetMarginBottom(const Length& v) {
-    SET_VAR(surround_, margin_.bottom_, v);
+    SET_VAR(surround_, margin_bottom_, v);
   }
 
   // margin-left
-  const Length& MarginLeft() const { return surround_->margin_.Left(); }
-  void SetMarginLeft(const Length& v) { SET_VAR(surround_, margin_.left_, v); }
+  const Length& MarginLeft() const { return surround_->margin_left_; }
+  void SetMarginLeft(const Length& v) { SET_VAR(surround_, margin_left_, v); }
 
   // margin-right
-  const Length& MarginRight() const { return surround_->margin_.Right(); }
-  void SetMarginRight(const Length& v) {
-    SET_VAR(surround_, margin_.right_, v);
-  }
+  const Length& MarginRight() const { return surround_->margin_right_; }
+  void SetMarginRight(const Length& v) { SET_VAR(surround_, margin_right_, v); }
 
   // -webkit-margin-before-collapse (aka -webkit-margin-top-collapse)
   static EMarginCollapse InitialMarginBeforeCollapse() {
     return kMarginCollapseCollapse;
   }
   EMarginCollapse MarginAfterCollapse() const {
     return static_cast<EMarginCollapse>(
         rare_non_inherited_data_->margin_after_collapse);
   }
   void SetMarginBeforeCollapse(EMarginCollapse c) {
@@ skipping 1697 matching lines @@
     return IsHorizontalWritingMode() ? MaxHeight() : MaxWidth();
   }
   const Length& LogicalMinWidth() const {
     return IsHorizontalWritingMode() ? MinWidth() : MinHeight();
   }
   const Length& LogicalMinHeight() const {
     return IsHorizontalWritingMode() ? MinHeight() : MinWidth();
   }
 
   // Margin utility functions.
-  bool HasMargin() const { return Margin().NonZero(); }
+  bool HasMargin() const {
+    return !MarginLeft().IsZero() || !MarginRight().IsZero() ||
+           !MarginTop().IsZero() || !MarginBottom().IsZero();
+  }
   bool HasMarginBeforeQuirk() const { return MarginBefore().Quirk(); }
   bool HasMarginAfterQuirk() const { return MarginAfter().Quirk(); }
-  const LengthBox& Margin() const { return surround_->margin_; }
-  const Length& MarginBefore() const {
-    return Margin().Before(GetWritingMode());
+  const Length& MarginBefore() const { return MarginBeforeUsing(this); }
+  const Length& MarginAfter() const { return MarginAfterUsing(this); }
+  const Length& MarginStart() const { return MarginStartUsing(this); }
+  const Length& MarginEnd() const { return MarginEndUsing(this); }
+  const Length& MarginOver() const {
+    return LengthBox::Over(GetWritingMode(), MarginTop(), MarginRight());
   }
-  const Length& MarginAfter() const { return Margin().After(GetWritingMode()); }
-  const Length& MarginStart() const {
-    return Margin().Start(GetWritingMode(), Direction());
+  const Length& MarginUnder() const {
+    return LengthBox::Under(GetWritingMode(), MarginBottom(), MarginLeft());
   }
-  const Length& MarginEnd() const {
-    return Margin().end(GetWritingMode(), Direction());
+  const Length& MarginStartUsing(const ComputedStyle* other) const {
+    return LengthBox::Start(other->GetWritingMode(), other->Direction(),
+                            MarginTop(), MarginLeft(), MarginRight(),
+                            MarginBottom());
   }
-  const Length& MarginOver() const { return Margin().Over(GetWritingMode()); }
-  const Length& MarginUnder() const { return Margin().Under(GetWritingMode()); }
-  const Length& MarginStartUsing(const ComputedStyle* other_style) const {
-    return Margin().Start(other_style->GetWritingMode(),
-                          other_style->Direction());
+  const Length& MarginEndUsing(const ComputedStyle* other) const {
+    return LengthBox::End(other->GetWritingMode(), other->Direction(),
+                          MarginTop(), MarginLeft(), MarginRight(),
+                          MarginBottom());
   }
-  const Length& MarginEndUsing(const ComputedStyle* other_style) const {
-    return Margin().end(other_style->GetWritingMode(),
-                        other_style->Direction());
+  const Length& MarginBeforeUsing(const ComputedStyle* other) const {
+    return LengthBox::Before(other->GetWritingMode(), MarginTop(), MarginLeft(),
+                             MarginRight());
   }
-  const Length& MarginBeforeUsing(const ComputedStyle* other_style) const {
-    return Margin().Before(other_style->GetWritingMode());
-  }
-  const Length& MarginAfterUsing(const ComputedStyle* other_style) const {
-    return Margin().After(other_style->GetWritingMode());
+  const Length& MarginAfterUsing(const ComputedStyle* other) const {
+    return LengthBox::After(other->GetWritingMode(), MarginBottom(),
+                            MarginLeft(), MarginRight());
   }
   void SetMarginStart(const Length&);
   void SetMarginEnd(const Length&);
+  bool MarginEqual(const ComputedStyle& other) const {

[nainar, 2017/04/18 06:58:49]

Please mention in the description that you are adding this function

[shend, 2017/04/18 07:54:25]

Done.

+    return MarginTop() == other.MarginTop() &&
+           MarginLeft() == other.MarginLeft() &&
+           MarginRight() == other.MarginRight() &&
+           MarginBottom() == other.MarginBottom();
+  }
 
   // Padding utility functions.
   const LengthBox& Padding() const { return surround_->padding_; }
   const Length& PaddingBefore() const {
     return Padding().Before(GetWritingMode());
   }
   const Length& PaddingAfter() const {
     return Padding().After(GetWritingMode());
   }
   const Length& PaddingStart() const {
@@ skipping 829 matching lines @@
   pseudo_bits_ |= 1 << (pseudo - kFirstPublicPseudoId);
 }
 
 inline bool ComputedStyle::HasPseudoElementStyle() const {
   return pseudo_bits_ & kElementPseudoIdMask;
 }
 
 }  // namespace blink
 
 #endif  // ComputedStyle_h