Chromium Code Reviews| Index: components/wallpaper/wallpaper_color_calculator.h |
| diff --git a/components/wallpaper/wallpaper_color_calculator.h b/components/wallpaper/wallpaper_color_calculator.h |
| index e282098dd115866e009ca4bce79b99a08d1716ed..801047ad9ce21b4a1deebdc5dc0dce6c20066756 100644 |
| --- a/components/wallpaper/wallpaper_color_calculator.h |
| +++ b/components/wallpaper/wallpaper_color_calculator.h |
| @@ -22,7 +22,7 @@ class TaskRunner; |
| namespace wallpaper { |
| class WallpaperColorCalculatorObserver; |
| -// Asynchronously calculates colors based on a wallpaper image. |
| +// Calculates colors based on a wallpaper image. |
| class WALLPAPER_EXPORT WallpaperColorCalculator { |
| public: |
| // |image|, |luma| and |saturation| are the input parameters to the color |
| @@ -38,7 +38,8 @@ class WALLPAPER_EXPORT WallpaperColorCalculator { |
| void RemoveObserver(WallpaperColorCalculatorObserver* observer); |
| // Initiates the calculation and returns false if the calculation fails to be |
| - // initiated. Callers should be aware that this will make |image_| read-only. |
| + // initiated. Observers may be notified synchronously or asynchronously. |
|
Evan Stade
2017/04/20 21:37:15
nit: each file should be consistent about one or t
bruthig
2017/04/21 15:42:08
Done.
|
| + // Callers should be aware that this will make |image_| read-only. |
| bool StartCalculation() WARN_UNUSED_RESULT; |
| SkColor prominent_color() const { return prominent_color_; } |
| @@ -51,6 +52,11 @@ class WALLPAPER_EXPORT WallpaperColorCalculator { |
| void SetTaskRunnerForTest(scoped_refptr<base::TaskRunner> task_runner); |
| private: |
| + // Handles asynchronous calculation results. |async_start_time| is used to |
| + // record duration metrics. |
| + void OnAsyncCalculationComplete(base::TimeTicks async_start_time, |
| + SkColor prominent_color); |
| + |
| // Notifies observers that a color calulation has completed. Called on the |
| // same thread that constructed |this|. |
| void NotifyCalculationComplete(SkColor prominent_color); |
| @@ -70,10 +76,6 @@ class WALLPAPER_EXPORT WallpaperColorCalculator { |
| // The task runner to run the calculation on. |
| scoped_refptr<base::TaskRunner> task_runner_; |
| - // The time that StartCalculation() was last called. Used for recording |
| - // timing metrics. |
| - base::Time start_calculation_time_; |
| - |
| base::ObserverList<WallpaperColorCalculatorObserver> observers_; |
| base::WeakPtrFactory<WallpaperColorCalculator> weak_ptr_factory_; |