tools/metrics/histograms/histograms.xml - Issue 2824883006: [ash-md] Reduce thread hopping for cheap wallpaper color extraction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2824883006: [ash-md] Reduce thread hopping for cheap wallpaper color extraction. (Closed)

Patch Set: Addressed comments from patch set patch set 6. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ce92b4a4b9b3383ccff650ee1c5c910ff9b38b75..a6004a7673c4571772c43a201e8eacc402cfd584 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -2283,6 +2283,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Ash.Wallpaper.ColorExtraction.Durations" units="ms">

+ <owner>bruthig@chromium.org</owner>

+ <owner>tbuckley@chromium.org</owner>

+ <summary>

+ The time taken to extract colors from wallpapers. Recorded each time the

+ wallpaper image changes.

+ </summary>

+</histogram>

+<histogram name="Ash.Wallpaper.ColorExtraction.UserDelay" units="ms">

+ <owner>bruthig@chromium.org</owner>

+ <owner>tbuckley@chromium.org</owner>

+ <summary>

+ The time taken to extract colors from 'expensive' wallpapers. Recorded each

+ time the wallpaper image changes and the color extraction is expected to be

+ expensive, e.g. image size > 100 pixels. This includes time spent

+ switching threads.

+ </summary>

+</histogram>

<owner>bruthig@chromium.org</owner>

<owner>tbuckley@chromium.org</owner>

@@ -2321,11 +2341,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

+ <obsolete>

+ Deprecated as of 04/2017 in favor of Ash.Wallpaper.ColorExtraction.Durations

+ and Ash.Wallpaper.ColorExtraction.UserDelay.

+ </obsolete>

<owner>bruthig@chromium.org</owner>

<owner>tbuckley@chromium.org</owner>

The time taken to extract colors from wallpapers. Recorded each time the

- wallpaper image changes.

+ wallpaper image changes. NOTE, this measure also included the time spent

+ jumping between threads, thus it was deprecated in favor of

+ Ash.Wallpaper.ColorExtraction.Durations.

</summary>

</histogram>

« no previous file with comments | « components/wallpaper/wallpaper_color_calculator_unittest.cc ('k') | no next file » | no next file with comments »