tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1ab43ba4ac96b04d3adebe858532cb222c2ad8f9..4c0e7c7402a577bae4a2dad6a6a7660d12c9cd39 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2274,6 +2274,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Ash.Wallpaper.AsyncTimeSpentExtractingColors" units="ms">
+  <owner>bruthig@chromium.org</owner>
+  <owner>tbuckley@chromium.org</owner>
+  <summary>
+    The asynchronous time taken to extract colors from wallpapers. Recorded each

[Evan Stade, 2017/04/19 13:44:31]

the name and description of this histogram seem a little off. This should
correlate to the user-visible delay before the wallpaper color is extracted, but
much (in some cases) most of that time is not spent extracting colors.

(Also "the asynchronous time taken" doesn't really make sense. I understand what
this means only because I'm familiar with the code.)

[bruthig, 2017/04/19 15:15:52]

I've reworked the naming and descriptions.
WDYT?

[Evan Stade, 2017/04/20 21:37:44]

looks good, thanks

+    time the wallpaper image changes and the color extraction is expected to be
+    expensive.
+  </summary>
+</histogram>
+
+<histogram name="Ash.Wallpaper.ColorExtraction.ExecutionType"

[Evan Stade, 2017/04/19 13:44:31]

I don't think this is necessary. Can't we get this by comparing the summed
buckets of TimeSpentExtractingColors and AsyncTimeSpent[...]

[bruthig, 2017/04/19 15:15:53]

Done.

+    enum="BooleanSynchronous">
+  <owner>bruthig@chromium.org</owner>
+  <owner>tbuckley@chromium.org</owner>
+  <summary>
+    Tracks whether the wallpaper color extraction algorithm was run
+    synchronously or asynchronously. Recorded each time the wallpaper image
+    changes.
+  </summary>
+</histogram>
+
 <histogram name="Ash.Wallpaper.ColorExtractionResult" enum="BooleanSuccess">
   <owner>bruthig@chromium.org</owner>
   <owner>tbuckley@chromium.org</owner>
@@ -2312,6 +2333,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="Ash.Wallpaper.TimeSpentExtractingColors" units="ms">
+  <obsolete>
+    Deprecated as of 04/2017 in favor of
+    Ash.Wallpaper.TimeSpentExtractingColors_v2 and
+    Ash.Wallpaper.AsyncTimeSpentExtractingColors.
+  </obsolete>
+  <owner>bruthig@chromium.org</owner>
+  <owner>tbuckley@chromium.org</owner>
+  <summary>
+    The time taken to extract colors from wallpapers. Recorded each time the
+    wallpaper image changes. NOTE, this measure also included the timespent
+    jumping between threads, thus it was deprecated in favor of
+    Ash.Wallpaper.TimeSpentExtractingColors_v2.
+  </summary>
+</histogram>
+
+<histogram name="Ash.Wallpaper.TimeSpentExtractingColors_v2" units="ms">
   <owner>bruthig@chromium.org</owner>
   <owner>tbuckley@chromium.org</owner>
   <summary>
@@ -85150,6 +85187,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="1" label="Suppressed"/>
 </enum>
 
+<enum name="BooleanSynchronous" type="int">
+  <int value="0" label="Asynchronous"/>
+  <int value="1" label="Synchronous"/>
+</enum>
+
 <enum name="BooleanTabDiscard" type="int">
   <int value="0" label="Memory OK, no discards"/>
   <int value="1" label="Memory low, tabs discarded"/>