media/capture/video/video_capture_system.h - Issue 2824883005: [Mojo Video Capture] Stop service when last client disconnects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/video_capture_system.h

Issue 2824883005: [Mojo Video Capture] Stop service when last client disconnects. (Closed)

Patch Set: Incorporate suggestions from PatchSet #2 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/video_capture_system.h

diff --git a/media/capture/video/video_capture_system.h b/media/capture/video/video_capture_system.h

index b0b6313123babdbc56bb1510348800c30ca1df0d..54b2dca704c4ea4bdd09f7675053943063e68145 100644

--- a/media/capture/video/video_capture_system.h

+++ b/media/capture/video/video_capture_system.h

@@ -10,6 +10,8 @@

namespace media {

+// GetDeviceInfosAsync() must be called at least once before calling

+// CreateDevice().

mcasas 2017/04/27 20:10:02 nit: Shouldn't this be enforced somehow?

chfremer 2017/04/27 23:48:14 Hmm, maybe I worded this too strongly. Actually, C

class CAPTURE_EXPORT VideoCaptureSystem {

public:

using DeviceInfoCallback =