[Mojo Video Capture] Stop service when last client disconnects.

services/video_capture/public/cpp/device_to_feedback_observer_adapter.h

Index: services/video_capture/public/cpp/device_to_feedback_observer_adapter.h
diff --git a/services/video_capture/public/cpp/device_to_feedback_observer_adapter.h b/services/video_capture/public/cpp/device_to_feedback_observer_adapter.h
index b35dab01d1701511cb2982cfd3f100a004cc5625..a4f9e68289648b6ca8b90ae98d6b2466f2897c26 100644
--- a/services/video_capture/public/cpp/device_to_feedback_observer_adapter.h
+++ b/services/video_capture/public/cpp/device_to_feedback_observer_adapter.h
@@ -15,14 +15,14 @@ namespace video_capture {
 class DeviceToFeedbackObserverAdapter
     : public media::VideoFrameConsumerFeedbackObserver {
  public:
-  DeviceToFeedbackObserverAdapter(mojom::DevicePtr device);
+  DeviceToFeedbackObserverAdapter(mojom::DevicePtr* device);
   ~DeviceToFeedbackObserverAdapter() override;
 
   // media::VideoFrameConsumerFeedbackObserver:
   void OnUtilizationReport(int frame_feedback_id, double utilization) override;
 
  private:
-  mojom::DevicePtr device_;
+  mojom::DevicePtr* device_;

[mcasas, 2017/04/27 00:22:15]

I'm surprised by this change, it seems unrelated to other
changes in this CL and it's in itself peculiar: mojom Ptrs
are move-only types, so holding a weak reference to one
such is non-intuitive.  The previous behaviour looks more
correct to me.

[chfremer, 2017/04/27 19:52:49]

Thanks for catching this. You are right, this change should not actually belong
to this CL. I believe it must somehow have propagated itself here through the
countless merges and reshuffles that the CLs have gone through on their way to
review. The change may make sense at a later CL. I guess if it is still needed,
we will see it when the time comes.

Reverted.

 };
 
 }  // namespace video_capture