Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: services/video_capture/service_impl.cc

Issue 2824883005: [Mojo Video Capture] Stop service when last client disconnects. (Closed)
Patch Set: Incorporate suggestions from PatchSet #2 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/video_capture/service_impl.h" 5 #include "services/video_capture/service_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "mojo/public/cpp/bindings/strong_binding.h"
8 #include "base/message_loop/message_loop.h" 8 #include "services/service_manager/public/cpp/interface_registry.h"
9 #include "media/capture/video/fake_video_capture_device_factory.h" 9 #include "services/service_manager/public/cpp/service_context.h"
10 #include "media/capture/video/video_capture_buffer_pool.h" 10 #include "services/video_capture/device_factory_provider_impl.h"
11 #include "media/capture/video/video_capture_buffer_tracker.h" 11 #include "services/video_capture/public/interfaces/constants.mojom.h"
12 #include "media/capture/video/video_capture_jpeg_decoder.h"
13 #include "media/capture/video/video_capture_system_impl.h"
14 #include "services/service_manager/public/cpp/service_info.h"
15 #include "services/video_capture/device_factory_media_to_mojo_adapter.h"
16
17 namespace {
18
19 // TODO(chfremer): Replace with an actual decoder factory.
20 // https://crbug.com/584797
21 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() {
22 return nullptr;
23 }
24
25 } // anonymous namespace
26 12
27 namespace video_capture { 13 namespace video_capture {
28 14
29 ServiceImpl::ServiceImpl() { 15 ServiceImpl::ServiceImpl()
30 registry_.AddInterface<mojom::Service>(this); 16 : shutdown_delay_in_seconds_(mojom::kDefaultShutdownDelayInSeconds),
31 } 17 weak_factory_(this) {}
32 18
33 ServiceImpl::~ServiceImpl() = default; 19 ServiceImpl::~ServiceImpl() = default;
34 20
21 void ServiceImpl::OnStart() {
22 DVLOG(3) << "Service Starting";
mcasas 2017/04/27 20:10:02 nit: consider removing these debugging DVLOG()s
chfremer 2017/04/27 23:48:14 Done.
23 ref_factory_ =
24 base::MakeUnique<service_manager::ServiceContextRefFactory>(base::Bind(
25 &ServiceImpl::MaybeRequestQuitDelayed, base::Unretained(this)));
26 registry_.AddInterface<mojom::DeviceFactoryProvider>(
27 // Unretained |this| is safe because |registry_| is owned by |this|.
28 base::Bind(&ServiceImpl::OnDeviceFactoryProviderRequest,
29 base::Unretained(this)));
30 }
31
35 void ServiceImpl::OnBindInterface( 32 void ServiceImpl::OnBindInterface(
36 const service_manager::ServiceInfo& source_info, 33 const service_manager::ServiceInfo& source_info,
37 const std::string& interface_name, 34 const std::string& interface_name,
38 mojo::ScopedMessagePipeHandle interface_pipe) { 35 mojo::ScopedMessagePipeHandle interface_pipe) {
36 DVLOG(3) << "Service Connecting";
39 registry_.BindInterface(source_info.identity, interface_name, 37 registry_.BindInterface(source_info.identity, interface_name,
40 std::move(interface_pipe)); 38 std::move(interface_pipe));
41 } 39 }
42 40
43 void ServiceImpl::Create(const service_manager::Identity& remote_identity, 41 bool ServiceImpl::OnServiceManagerConnectionLost() {
44 mojom::ServiceRequest request) { 42 DVLOG(3) << "Service Stopping";
45 service_bindings_.AddBinding(this, std::move(request)); 43 return true;
46 } 44 }
47 45
48 void ServiceImpl::ConnectToDeviceFactory(mojom::DeviceFactoryRequest request) { 46 void ServiceImpl::OnDeviceFactoryProviderRequest(
49 LazyInitializeDeviceFactory(); 47 mojom::DeviceFactoryProviderRequest request) {
50 factory_bindings_.AddBinding(device_factory_.get(), std::move(request)); 48 mojo::MakeStrongBinding(
49 base::MakeUnique<DeviceFactoryProviderImpl>(
50 ref_factory_->CreateRef(),
51 // Use of unretained |this| is safe, because the
52 // VideoCaptureServiceImpl has shared ownership of |this| via the
53 // reference created by ref_factory->CreateRef().
54 base::Bind(&ServiceImpl::SetShutdownDelayInSeconds,
55 base::Unretained(this))),
56 std::move(request));
51 } 57 }
52 58
53 void ServiceImpl::ConnectToFakeDeviceFactory( 59 void ServiceImpl::SetShutdownDelayInSeconds(float seconds) {
54 mojom::DeviceFactoryRequest request) { 60 DVLOG(3) << "Shutdown delay set to " << seconds << " seconds.";
55 LazyInitializeFakeDeviceFactory(); 61 shutdown_delay_in_seconds_ = seconds;
56 fake_factory_bindings_.AddBinding(fake_device_factory_.get(),
57 std::move(request));
58 } 62 }
59 63
60 void ServiceImpl::LazyInitializeDeviceFactory() { 64 void ServiceImpl::MaybeRequestQuitDelayed() {
61 if (device_factory_) 65 DVLOG(3) << "Scheduling service to quit";
62 return; 66 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
63 67 FROM_HERE,
64 // Create the platform-specific device factory. 68 base::Bind(&ServiceImpl::MaybeRequestQuit, weak_factory_.GetWeakPtr()),
65 // Task runner does not seem to actually be used. 69 base::TimeDelta::FromSeconds(shutdown_delay_in_seconds_));
66 std::unique_ptr<media::VideoCaptureDeviceFactory> media_device_factory =
67 media::VideoCaptureDeviceFactory::CreateFactory(
68 base::MessageLoop::current()->task_runner());
69 auto video_capture_system = base::MakeUnique<media::VideoCaptureSystemImpl>(
70 std::move(media_device_factory));
71
72 device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
73 std::move(video_capture_system), base::Bind(CreateJpegDecoder));
74 } 70 }
75 71
76 void ServiceImpl::LazyInitializeFakeDeviceFactory() { 72 void ServiceImpl::MaybeRequestQuit() {
77 if (fake_device_factory_) 73 DCHECK(ref_factory_);
78 return; 74 if (ref_factory_->HasNoRefs()) {
79 75 DVLOG(3) << "Service gonna quit now";
80 auto factory = base::MakeUnique<media::FakeVideoCaptureDeviceFactory>(); 76 context()->RequestQuit();
81 auto video_capture_system = 77 } else {
82 base::MakeUnique<media::VideoCaptureSystemImpl>(std::move(factory)); 78 DVLOG(3) << "Service no longer quitting";
83 79 }
84 fake_device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
85 std::move(video_capture_system), base::Bind(&CreateJpegDecoder));
86 } 80 }
87 81
88 } // namespace video_capture 82 } // namespace video_capture
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698