Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2824873002: Fix cast exception when a Handle gets a wrong element because of name conflict. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix cast exception when a Handle gets a wrong element because of name conflict. For example: type 'TopLevelVariableElementImpl' is not a subtype of type 'FunctionTypeAliasElement' in type cast where TopLevelVariableElementImpl is from package:analyzer/src/dart/element/element.dart FunctionTypeAliasElement is from package:analyzer/dart/element/element.dart R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0adb817be27994916cd256eb90e22ca6a6a1446b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M pkg/analysis_server/analysis_server.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-17 21:34:22 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-17 21:37:54 UTC) #2
scheglov
3 years, 8 months ago (2017-04-17 21:52:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0adb817be27994916cd256eb90e22ca6a6a1446b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698