Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2824843002: MD Settings: Display: Disable orientaiton control in tablet mode (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 3 months ago
Reviewers:
malaykeshav, oshima
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, extensions-reviews_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display: Disable orientaiton control in tablet mode This CL: * Adds an isMaximizedMode property to the system.display api. * Sets the primary display property to the result of MaximizeModeController::IsMaximizeModeWindowManagerEnabled. * Disables the orientation UI when isMaximizedMode is true for a display. BUG=704929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Add test and trigger onDisplayChanged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M ash/shell.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 2 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display.js View 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/common/api/system_display.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/system_display.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/display_observer.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
stevenjb
3 years, 8 months ago (2017-04-17 20:23:40 UTC) #3
stevenjb
OK, this should be ready for review now.
3 years, 8 months ago (2017-04-18 18:28:00 UTC) #4
malaykeshav
lgtm
3 years, 8 months ago (2017-04-18 19:13:36 UTC) #5
stevenjb
oshima@ - ping
3 years, 8 months ago (2017-04-19 16:06:42 UTC) #6
oshima
sorry for delay. I'll review in an hour.
3 years, 8 months ago (2017-04-19 20:28:26 UTC) #7
oshima
I think it's better to add device rotation support attribute to display like touch support. ...
3 years, 8 months ago (2017-04-19 22:28:35 UTC) #8
stevenjb
3 years, 8 months ago (2017-04-19 22:45:07 UTC) #9
OK, sgtm

Powered by Google App Engine
This is Rietveld 408576698