Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2824823004: Remove Compiler and JavaScriptBackend from program_builder and collector. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Compiler and JavaScriptBackend from program_builder and collector. This is a step towards passing data object directly instead of accessing data on JavaScriptBackend. This is needed to support an element switch between resolution and codegen. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/407645660c4d2160de5821e532f3103f431c51a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -146 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +27 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 11 chunks +91 lines, -80 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 9 chunks +76 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/registry.dart View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-18 14:38:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 8 months ago (2017-04-18 16:06:07 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-19 08:45:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
407645660c4d2160de5821e532f3103f431c51a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698