Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: net/quic/core/quic_flow_controller.cc

Issue 2824773005: Improve QUIC flow-control commentary and variable-names. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_flow_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_flow_controller.cc
diff --git a/net/quic/core/quic_flow_controller.cc b/net/quic/core/quic_flow_controller.cc
index 1c27276a1cd89dd8102ea980248480261d5663b7..715d938c44e106d5146a4017644e28bf50f0ecff 100644
--- a/net/quic/core/quic_flow_controller.cc
+++ b/net/quic/core/quic_flow_controller.cc
@@ -250,9 +250,12 @@ bool QuicFlowController::UpdateSendWindowOffset(
<< " current offset: " << send_window_offset_
<< " bytes_sent: " << bytes_sent_;
- const bool blocked = IsBlocked();
+ // The flow is now unblocked but could have also been unblocked
+ // before. Return true iff this update caused a change from blocked
+ // to unblocked.
+ const bool was_previously_blocked = IsBlocked();
send_window_offset_ = new_send_window_offset;
- return blocked;
+ return was_previously_blocked;
}
void QuicFlowController::EnsureWindowAtLeast(QuicByteCount window_size) {
« no previous file with comments | « net/quic/core/quic_flow_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698