Remove usage of Tab's |url| property from Tab.

ios/chrome/browser/tabs/tab.mm

Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index 7f18cebaf9fa2814eec777f04b0a49647065d55a..fbae3dc3f7538ef0a44ae0eccf44a2e224188369 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -590,7 +590,7 @@ - (void)setParentTabModel:(TabModel*)model {
 
 - (NSString*)description {
   return [NSString stringWithFormat:@"%p ... %@ - %s", self, self.title,
-                                    self.url.spec().c_str()];
+                                    self.visibleURL.spec().c_str()];

[kkhorimoto, 2017/04/14 21:05:16]

It seems to make the most sense to use the URL that would be displayed in the
omnibox.

 }
 
 - (CRWWebController*)webController {
@@ -665,8 +665,8 @@ - (NSString*)originalTitle {
 
 - (NSString*)urlDisplayString {
   base::string16 urlText = url_formatter::FormatUrl(
-      self.url, url_formatter::kFormatUrlOmitNothing, net::UnescapeRule::SPACES,
-      nullptr, nullptr, nullptr);
+      self.visibleURL, url_formatter::kFormatUrlOmitNothing,

[kkhorimoto, 2017/04/14 21:05:16]

It seems to make the most sense to use the URL that would be displayed in the
omnibox.

+      net::UnescapeRule::SPACES, nullptr, nullptr, nullptr);
   return base::SysUTF16ToNSString(urlText);
 }
 
@@ -694,7 +694,7 @@ - (NSString*)tabId {
 }
 
 - (void)fetchFavicon {
-  const GURL& url = self.url;
+  const GURL& url = self.visibleURL;

[kkhorimoto, 2017/04/14 21:05:16]

Since favicon fetching occurs during a load, we should be fetching the favicon
for the page that is being loaded.

   if (!url.is_valid())
     return;
 
@@ -893,7 +893,8 @@ - (void)saveTitleToHistoryDB {
       ios::HistoryServiceFactory::GetForBrowserState(
           browserState_, ServiceAccessType::IMPLICIT_ACCESS);
   DCHECK(historyService);
-  historyService->SetPageTitle(self.url, base::SysNSStringToUTF16(title));
+  historyService->SetPageTitle(self.lastCommittedURL,
+                               base::SysNSStringToUTF16(title));

[kkhorimoto, 2017/04/14 21:05:16]

|title| is fetched via WebState::GetTitle(), which uses the last committed URL.

 }
 
 - (void)addCurrentEntryToHistoryDB {
@@ -1178,7 +1179,7 @@ - (BOOL)openExternalURL:(const GURL&)url
     // Compose u2f-x-callback URL and update urlToOpen.
     finalURL = [U2FController_ XCallbackFromRequestURL:finalURL
                                              originURL:origin
-                                                tabURL:self.url
+                                                tabURL:self.lastCommittedURL

[kkhorimoto, 2017/04/14 21:05:16]

If an external URL is being opened by a page, then we want the xcallback to
return to the page that is opening the URL.  Since a navigation needs to be
committed before opening a URL, we should use the last committed here.

                                                  tabID:self.tabId];
 
     if (!finalURL.is_valid()) {
@@ -1286,19 +1287,21 @@ - (void)handleExportableFile:(net::HttpResponseHeaders*)headers {
     headers->GetNormalizedHeader("content-disposition", &contentDisposition);
   std::string defaultFilename =
       l10n_util::GetStringUTF8(IDS_IOS_OPEN_IN_FILE_DEFAULT_TITLE);
+  const GURL& committedURL = self.lastCommittedURL;

[kkhorimoto, 2017/04/14 21:05:16]

If a file is being opened by a page, then we want the xcallback to
return to the page that is opening the URL.  Since a navigation needs to be
committed before opening a URL, we should use the last committed here.

   base::string16 filename =
-      net::GetSuggestedFilename(self.url, contentDisposition,
+      net::GetSuggestedFilename(committedURL, contentDisposition,
                                 "",                 // referrer-charset
                                 "",                 // suggested-name
                                 "application/pdf",  // mime-type
                                 defaultFilename);
   [[self openInController]
-      enableWithDocumentURL:self.url
+      enableWithDocumentURL:committedURL
           suggestedFilename:base::SysUTF16ToNSString(filename)];
 }
 
 - (void)countMainFrameLoad {
-  if ([self isPrerenderTab] || [self url].SchemeIs(kChromeUIScheme)) {
+  if ([self isPrerenderTab] ||
+      self.lastCommittedURL.SchemeIs(kChromeUIScheme)) {

[kkhorimoto, 2017/04/14 21:05:16]

If we're counting a main frame load, then we can assume that the load has
finished and that the navigation is committed.

     return;
   }
   base::RecordAction(UserMetricsAction("MobilePageLoaded"));
@@ -1359,7 +1362,7 @@ - (void)loadReaderModeHTML:(NSString*)html forURL:(const GURL&)url {
   // not changed since reader mode was requested. This could happen for example
   // if the page does a late redirect itself or if the user tapped on a link and
   // triggered reader mode before the page load is detected by webState.
-  if (url == self.url)
+  if (url == self.visibleURL)

[kkhorimoto, 2017/04/14 21:05:16]

Reader mode HTML is loaded when a load is taking too long, so we should use the
visible URL to reflect the navigation that is occurring.

     [self.webController loadHTMLForCurrentURL:html];
 
   [self.readerModeController exitReaderMode];
@@ -1471,7 +1474,7 @@ - (void)webWillAddPendingURL:(const GURL&)url
   // into a NavigationManager observer callback, so it doesn't need to be
   // checked in several places.
   if (isUserNavigationEvent && !isPrerenderTab_ &&
-      ![self navigationManager]->GetPendingItem() && url != self.url) {
+      ![self navigationManager]->GetPendingItem() && url != self.visibleURL) {
     base::RecordAction(UserMetricsAction("MobileTabClobbered"));
     if ([parentTabModel_ tabUsageRecorder])
       [parentTabModel_ tabUsageRecorder]->RecordPageLoadStart(self);