Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: net/http/http_stream_factory_impl.cc

Issue 2824513003: Add one more histogram to log how many Request are still pending when (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl.cc
diff --git a/net/http/http_stream_factory_impl.cc b/net/http/http_stream_factory_impl.cc
index 9c38e69f1c9d565b246f8cda6c6087eef0541d51..10d1aab34a41dbd2ee41d3f09fc6b22eed9dc2e3 100644
--- a/net/http/http_stream_factory_impl.cc
+++ b/net/http/http_stream_factory_impl.cc
@@ -372,6 +372,7 @@ void HttpStreamFactoryImpl::AddJobControllerCountToHistograms() {
int alt_job_count = 0;
int main_job_count = 0;
+ int pending_request_count = 0;
int preconnect_controller_count = 0;
for (const auto& job_controller : job_controller_set_) {
DCHECK(job_controller->HasPendingAltJob() ||
@@ -382,6 +383,8 @@ void HttpStreamFactoryImpl::AddJobControllerCountToHistograms() {
continue;
}
// For non-preconnects.
+ if (job_controller->HasPendingRequest())
+ pending_request_count++;
if (job_controller->HasPendingAltJob())
alt_job_count++;
if (job_controller->HasPendingMainJob())
@@ -393,6 +396,8 @@ void HttpStreamFactoryImpl::AddJobControllerCountToHistograms() {
alt_job_count);
UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfNonPreconnectMainJob",
main_job_count);
+ UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfPendingRequest",
Steven Holte 2017/04/14 22:46:44 It seems like 1M is much bigger than range of actu
+ pending_request_count);
}
void HttpStreamFactoryImpl::DumpMemoryStats(
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698