pkg/compiler/lib/src/kernel/element_adapter.dart - Issue 2824423002: Compute NativeBasicData for KernelWorldBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/kernel/element_adapter.dart

Issue 2824423002: Compute NativeBasicData for KernelWorldBuilder (Closed)

Patch Set: Put computeNativeBasicData into KernelAnnotationProcessor. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/kernel/element_adapter.dart

diff --git a/pkg/compiler/lib/src/kernel/element_adapter.dart b/pkg/compiler/lib/src/kernel/element_adapter.dart

index db353f19aa296a4abd32d7f71ba81b0d1369130f..67fef3496f578db806501a6c565ae0c739447519 100644

--- a/pkg/compiler/lib/src/kernel/element_adapter.dart

+++ b/pkg/compiler/lib/src/kernel/element_adapter.dart

@@ -193,6 +193,7 @@ abstract class KernelElementAdapterMixin implements KernelElementAdapter {

/// Converts [annotations] into a list of [ConstantExpression]s.

List<ConstantExpression> getMetadata(List<ir.Expression> annotations) {

+ if (annotations.isEmpty) return const <ConstantExpression>[];

List<ConstantExpression> metadata = <ConstantExpression>[];

annotations.forEach((ir.Expression node) {

ConstantExpression constant = new Constantifier(this).visit(node);