Issue 2824323002: Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824323002: Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)." (Closed)

Created:
3 years, 8 months ago by Jacob

Modified:
3 years, 8 months ago

Reviewers:
regis, mfairhurst

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)." This reverts commit a84b6b7f7bf486b1189eb69c3a6ae2ee185c8d8a. BUG= Committed: https://github.com/dart-lang/sdk/commit/b7995140f8170cf54444d90154e3e2647dc786f4

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -73 lines)			Patch
M	runtime/vm/object.cc	View	1 chunk	+5 lines, -10 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	tests/language/stacktrace_demangle_ctors_test.dart	View	1 chunk	+0 lines, -59 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

Committed patchset #1 (id:1) manually as b7995140f8170cf54444d90154e3e2647dc786f4 (presubmit successful).

3 years, 8 months ago (2017-04-18 23:48:39 UTC) #4

regis

3 years, 8 months ago (2017-04-19 00:13:55 UTC) #5

Message was sent while issue was closed.

On 2017/04/18 23:48:39, Jacob wrote:
> Committed patchset #1 (id:1) manually as
> b7995140f8170cf54444d90154e3e2647dc786f4 (presubmit successful).

lgtm

Thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages