Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: net/http/http_stream_factory_impl.cc

Issue 2824313002: Split JobController count histograms into three separate histograms: (Closed)
Patch Set: remove redundant DCHECKs Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl.cc
diff --git a/net/http/http_stream_factory_impl.cc b/net/http/http_stream_factory_impl.cc
index a16c22f9edb8cf4f1dee822791727ba60ece2169..f84340a97d71b8c533892cb6ef043099b55f3110 100644
--- a/net/http/http_stream_factory_impl.cc
+++ b/net/http/http_stream_factory_impl.cc
@@ -372,8 +372,8 @@ void HttpStreamFactoryImpl::AddJobControllerCountToHistograms() {
int alt_job_count = 0;
int main_job_count = 0;
- int pending_request_count = 0;
- int preconnect_controller_count = 0;
+ size_t num_controllers_with_request = 0;
+ size_t num_controllers_for_preconnect = 0;
for (const auto& job_controller : job_controller_set_) {
DCHECK(job_controller->HasPendingAltJob() ||
job_controller->HasPendingMainJob());
@@ -383,25 +383,33 @@ void HttpStreamFactoryImpl::AddJobControllerCountToHistograms() {
job_controller->LogHistograms();
// For a preconnect controller, it should have exactly the main job.
if (job_controller->is_preconnect()) {
- preconnect_controller_count++;
+ num_controllers_for_preconnect++;
continue;
}
// For non-preconnects.
if (job_controller->HasPendingRequest())
- pending_request_count++;
+ num_controllers_with_request++;
if (job_controller->HasPendingAltJob())
alt_job_count++;
if (job_controller->HasPendingMainJob())
main_job_count++;
}
- UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfPreconnect",
- preconnect_controller_count);
+ UMA_HISTOGRAM_COUNTS_1M(
+ "Net.JobControllerSet.CountOfJobController.Preconnect",
+ num_controllers_for_preconnect);
+ UMA_HISTOGRAM_COUNTS_1M(
+ "Net.JobControllerSet.CountOfJobController.NonPreconnect.PendingRequest",
+ num_controllers_with_request);
+
+ UMA_HISTOGRAM_COUNTS_1M(
+ "Net.JobControllerSet.CountOfJobController.NonPreconnect.RequestGone",
+ job_controller_set_.size() - num_controllers_for_preconnect -
+ num_controllers_with_request);
+
UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfNonPreconnectAltJob",
alt_job_count);
UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfNonPreconnectMainJob",
main_job_count);
- UMA_HISTOGRAM_COUNTS_1M("Net.JobControllerSet.CountOfPendingRequest",
- pending_request_count);
}
void HttpStreamFactoryImpl::DumpMemoryStats(
@@ -415,11 +423,11 @@ void HttpStreamFactoryImpl::DumpMemoryStats(
pmd->CreateAllocatorDump(name);
size_t alt_job_count = 0;
size_t main_job_count = 0;
- size_t preconnect_controller_count = 0;
+ size_t num_controllers_for_preconnect = 0;
for (const auto& it : job_controller_set_) {
// For a preconnect controller, it should have exactly the main job.
if (it->is_preconnect()) {
- preconnect_controller_count++;
+ num_controllers_for_preconnect++;
continue;
}
// For non-preconnects.
@@ -447,7 +455,7 @@ void HttpStreamFactoryImpl::DumpMemoryStats(
// The number of preconnect controllers.
factory_dump->AddScalar("preconnect_count",
base::trace_event::MemoryAllocatorDump::kUnitsObjects,
- preconnect_controller_count);
+ num_controllers_for_preconnect);
}
} // namespace net
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698