Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2824193002: Enable use_once_callback for //content/common/*.mojom (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index f73acbb0fe982c08b97a0d0af9eec142837e6f94..835f079079a489cbdbd0cfbad009f9673ad8d740 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -68,11 +68,11 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
public mojom::ServiceWorkerEventDispatcher {
public:
using SyncCallback =
- base::Callback<void(ServiceWorkerStatusCode,
- base::Time /* dispatch_event_time */)>;
+ base::OnceCallback<void(ServiceWorkerStatusCode,
+ base::Time /* dispatch_event_time */)>;
using FetchCallback =
- base::Callback<void(ServiceWorkerStatusCode,
- base::Time /* dispatch_event_time */)>;
+ base::OnceCallback<void(ServiceWorkerStatusCode,
+ base::Time /* dispatch_event_time */)>;
// Returns a thread-specific client instance. This does NOT create a
// new instance.
@@ -231,54 +231,53 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
const ServiceWorkerVersionAttributes& attrs);
// mojom::ServiceWorkerEventDispatcher
- void DispatchActivateEvent(
- const DispatchActivateEventCallback& callback) override;
+ void DispatchActivateEvent(DispatchActivateEventCallback callback) override;
void DispatchBackgroundFetchAbortEvent(
const std::string& tag,
- const DispatchBackgroundFetchAbortEventCallback& callback) override;
+ DispatchBackgroundFetchAbortEventCallback callback) override;
void DispatchBackgroundFetchClickEvent(
const std::string& tag,
mojom::BackgroundFetchState state,
- const DispatchBackgroundFetchClickEventCallback& callback) override;
+ DispatchBackgroundFetchClickEventCallback callback) override;
void DispatchBackgroundFetchFailEvent(
const std::string& tag,
const std::vector<BackgroundFetchSettledFetch>& fetches,
- const DispatchBackgroundFetchFailEventCallback& callback) override;
+ DispatchBackgroundFetchFailEventCallback callback) override;
void DispatchBackgroundFetchedEvent(
const std::string& tag,
const std::vector<BackgroundFetchSettledFetch>& fetches,
- const DispatchBackgroundFetchedEventCallback& callback) override;
+ DispatchBackgroundFetchedEventCallback callback) override;
void DispatchExtendableMessageEvent(
mojom::ExtendableMessageEventPtr event,
- const DispatchExtendableMessageEventCallback& callback) override;
+ DispatchExtendableMessageEventCallback callback) override;
void DispatchFetchEvent(
int fetch_event_id,
const ServiceWorkerFetchRequest& request,
mojom::FetchEventPreloadHandlePtr preload_handle,
mojom::ServiceWorkerFetchResponseCallbackPtr response_callback,
- const DispatchFetchEventCallback& callback) override;
+ DispatchFetchEventCallback callback) override;
void DispatchNotificationClickEvent(
const std::string& notification_id,
const PlatformNotificationData& notification_data,
int action_index,
const base::Optional<base::string16>& reply,
- const DispatchNotificationClickEventCallback& callback) override;
+ DispatchNotificationClickEventCallback callback) override;
void DispatchNotificationCloseEvent(
const std::string& notification_id,
const PlatformNotificationData& notification_data,
- const DispatchNotificationCloseEventCallback& callback) override;
+ DispatchNotificationCloseEventCallback callback) override;
void DispatchPushEvent(const PushEventPayload& payload,
- const DispatchPushEventCallback& callback) override;
+ DispatchPushEventCallback callback) override;
void DispatchSyncEvent(
const std::string& tag,
blink::mojom::BackgroundSyncEventLastChance last_chance,
- const DispatchSyncEventCallback& callback) override;
+ DispatchSyncEventCallback callback) override;
void DispatchPaymentRequestEvent(
int payment_request_id,
payments::mojom::PaymentAppRequestPtr app_request,
payments::mojom::PaymentAppResponseCallbackPtr response_callback,
- const DispatchPaymentRequestEventCallback& callback) override;
- void Ping(const PingCallback& callback) override;
+ DispatchPaymentRequestEventCallback callback) override;
+ void Ping(PingCallback callback) override;
void OnInstallEvent(int request_id);
void OnNotificationClickEvent(

Powered by Google App Engine
This is Rietveld 408576698