Fix packing localized strings for //remoting.

remoting/resources/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//remoting/remoting_locales.gni")
 import("//tools/grit/grit_rule.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
@@ skipping 29 matching lines @@
     "../webapp/crd/js/host_setup_dialog.js",
     "../webapp/crd/js/host_table_entry.js",
     "../webapp/crd/manifest.json.jinja2",
     "../webapp/crd/js/paired_client_manager.js",
     "../webapp/crd/js/desktop_remoting.js",
     "../webapp/crd/js/window_frame.js",
   ]
 
   inputs = [ "remoting_strings.grd" ] + sources_to_verify
 
-  stampfile = "$root_build_dir/remoting_resources_verified_stamp"
+  stampfile = "$root_out_dir/remoting_resources_verified_stamp"

[Wez, 2017/04/18 18:05:26]

These changes don't seem related to the CL description?

[sdefresne, 2017/04/19 08:59:03]

Those changes correspond to the following part of the CL description:

  Fix warning about multiple target generating the same files when doing
  a fat build on iOS.

Without those, I get warning about multiple targets generating the same file;
the targets are //remoting/resources:verify_resources and
//remoting/resources:verify_resources(//build/toolchain/mac:ios_clang_arm).

[Wez, 2017/04/20 03:41:21]

Acknowledged, but consider clarifying in the description that you're fixing this
by fixing the output filenames of these steps. :)

   outputs = [
     stampfile,
   ]
 
   args = [
            "-t",
            rebase_path(stampfile, root_build_dir),
            "-r",
            rebase_path("remoting_strings.grd", root_build_dir),
          ] + rebase_path(sources_to_verify, root_build_dir)
@@ skipping 47 matching lines @@
   }
 }
 
 action("copy_locales") {
   script = "../tools/build/remoting_copy_locales.py"
 
   # The gyp build calls out to Python, but the Python just computes a simple
   # replacement over the locales. Here, we can do this in GN script by
   # pretending the locale list is a list of files. The {{source_name_part}}
   # will just expand to the locale name.
-  inputs = process_file_template(remoting_locales,
-                                 [ "$target_gen_dir/{{source_name_part}}.pak" ])
+  inputs = process_file_template(
+          remoting_locales,
+          [ "$root_gen_dir/remoting/resources/{{source_name_part}}.pak" ])
 
   # Likewise, process the outputs in the same way as the inputs.
   if (is_mac || is_ios) {
     # On mac, use underscores instead of hyphens and put the files in a
     # different place.
     outputs = process_file_template(
             remoting_locales_with_underscores,
-            [ "$root_build_dir/remoting/resources/{{source_name_part}}.lproj/locale.pak" ])
+            [ "$root_out_dir/remoting/resources/{{source_name_part}}.lproj/locale.pak" ])
   } else {
     outputs = process_file_template(
             remoting_locales,
-            [ "$root_build_dir/remoting_locales/{{source_name_part}}.pak" ])
+            [ "$root_out_dir/remoting_locales/{{source_name_part}}.pak" ])
   }
 
   args = [
            "-p",
            current_os,
            "-g",
            rebase_path(root_gen_dir, root_build_dir),
            "-x",
            rebase_path(root_out_dir, root_build_dir),
          ] + remoting_locales
 
   deps = [
     ":strings",
   ]
 }