Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2824143002: Improve documentation for `Future.wait`. (Closed)

Created:
3 years, 8 months ago by floitsch
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add another sentence. #

Total comments: 4

Patch Set 3 : Address comments and rewording. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M sdk/lib/async/future.dart View 1 2 1 chunk +20 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
floitsch
3 years, 8 months ago (2017-04-18 08:58:15 UTC) #2
floitsch
ping.
3 years, 8 months ago (2017-04-25 17:34:06 UTC) #3
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2824143002/diff/20001/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/2824143002/diff/20001/sdk/lib/async/future.dart#newcode293 sdk/lib/async/future.dart:293: * complete. Maybe: are complete -> have completed ...
3 years, 8 months ago (2017-04-26 08:28:46 UTC) #4
floitsch
https://codereview.chromium.org/2824143002/diff/20001/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/2824143002/diff/20001/sdk/lib/async/future.dart#newcode293 sdk/lib/async/future.dart:293: * complete. On 2017/04/26 08:28:46, Lasse Reichstein Nielsen wrote: ...
3 years, 8 months ago (2017-04-26 15:33:49 UTC) #5
floitsch
3 years, 8 months ago (2017-04-26 15:34:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6772402aa76fdf6e304a639f2f523e7797684920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698