Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2824083002: Fix 29264: remove access to the network on source-map unit test (Closed)

Created:
3 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 8 months ago
Reviewers:
Bob Nystrom, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix 29264: remove access to the network on source-map unit test BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/60964ab7350ec40c759a86df2eae4c978f9b521e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M tests/compiler/dart2js/source_map_pub_build_validity_test.dart View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
3 years, 8 months ago (2017-04-18 00:09:48 UTC) #2
Siggi Cherem (dart-lang)
3 years, 8 months ago (2017-04-18 19:52:24 UTC) #4
floitsch
LGTM.
3 years, 8 months ago (2017-04-19 09:35:16 UTC) #5
Siggi Cherem (dart-lang)
3 years, 8 months ago (2017-04-19 15:47:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
60964ab7350ec40c759a86df2eae4c978f9b521e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698