Remove override of View::HitTestRect() from ImageView

Remove override of View::HitTestRect() from ImageView

The override of View::HitTestRect() in ImageView forces hit
testing to fail if the |interactive_| member is false, which
prevents the view from accepting events. Since the |interactive_|
member is unrelated to location, it is better to move this logic
into an override of EventTarget::CanAcceptEvent() instead.

BUG=374325
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272117

[tdanderson, 2014-05-16 18:48:56]

Sadrul, PTAL.

[sadrul, 2014-05-21 15:44:03]

https://codereview.chromium.org/282403002/diff/1/ui/views/controls/image_view.cc
File ui/views/controls/image_view.cc (right):

https://codereview.chromium.org/282403002/diff/1/ui/views/controls/image_view...
ui/views/controls/image_view.cc:209: return interactive_;
Should this be 'interactive_ && View::CanAcceptEvent(event)'?

[tdanderson, 2014-05-21 21:07:49]

Comment addressed. Sadrul, can you please take another look?

https://codereview.chromium.org/282403002/diff/1/ui/views/controls/image_view.cc
File ui/views/controls/image_view.cc (right):

https://codereview.chromium.org/282403002/diff/1/ui/views/controls/image_view...
ui/views/controls/image_view.cc:209: return interactive_;
On 2014/05/21 15:44:03, sadrul wrote:
> Should this be 'interactive_ && View::CanAcceptEvent(event)'?

Done.

[sadrul, 2014-05-21 21:55:00]

lgtm

[tdanderson, 2014-05-21 22:23:07]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-05-21 22:27:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/282403002/20001

[commit-bot: I haz the power, 2014-05-22 04:34:04]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-22 05:56:01]

Change committed as 272117

[tdanderson, 2014-05-22 20:59:52]

A revert of this CL has been created in
https://codereview.chromium.org/286903022/ by tdanderson@chromium.org.

The reason for reverting is: Breaks mouse hover on image buttons (see
https://code.google.com/p/chromium/issues/detail?id=376478). tdanderson@ will
investigate..