Chromium Code Reviews
Help | Chromium Project | Sign in
(9)

Issue 2824014: Move the Mozilla-derived code in net/base/keygen_handler_nss.cc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by wtc
Modified:
3 years, 12 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move the Mozilla-derived code in net/base/keygen_handler_nss.cc to the new net/third_party/mozilla_security_manager directory. Fix nits. R=mattm,davidben BUG=148 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50259

Patch Set 1 #

Patch Set 2 : Update comments and LICENSE. #

Patch Set 3 : Fix nits in LICENSE. #

Total comments: 1

Patch Set 4 : Update URL in README.chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -267 lines) Patch
M net/base/keygen_handler_nss.cc View 1 chunk +5 lines, -235 lines 0 comments Download
M net/net.gyp View 1 2 chunks +4 lines, -0 lines 0 comments Download
A + net/third_party/mozilla_security_manager/LICENSE View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + net/third_party/mozilla_security_manager/README.chromium View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A net/third_party/mozilla_security_manager/nsKeygenHandler.h View 1 chunk +56 lines, -0 lines 0 comments Download
A + net/third_party/mozilla_security_manager/nsKeygenHandler.cpp View 1 9 chunks +59 lines, -28 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
wtc
4 years, 10 months ago (2010-06-17 23:28:21 UTC) #1
mattm
lgtm with comments
4 years, 10 months ago (2010-06-18 02:22:45 UTC) #2
mattm
oops, used the wrong reply link. http://codereview.chromium.org/2824014/diff/14001/15004 File net/third_party/mozilla_security_manager/README.chromium (right): http://codereview.chromium.org/2824014/diff/14001/15004#newcode4 net/third_party/mozilla_security_manager/README.chromium:4: Version: Mozilla 1.9.2 ...
4 years, 10 months ago (2010-06-18 02:23:07 UTC) #3
davidben (use chromium.org)
4 years, 10 months ago (2010-06-18 02:29:36 UTC) #4
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 98db9e2