Chromium Code Reviews
Help | Chromium Project | Sign in
(120)

Issue 2824004: Not meant to be reviewed or checked in: bookmark bar dragging 06/14/2010

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by kinnetica
Modified:
2 years ago
Reviewers:
Nico
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Not meant to be reviewed or checked in: bookmark bar dragging 06/14/2010 Dragging should only work in one direction (pick up drag and only move left to right or right to left -- not both in one drag). It should work as expected, with folders opening correctly on mouse over and other bookmarks moving to the side. To have this work in both directions, I need a way of knowing the current index of the bookmark I am dragging in relation to the other bookmarks in the bar. I've tried to fix this two different ways, but none really worked that well. There's a bug somewhere in this code where it freezes up sometimes when being dragged over a folder (i haven't been able to reproduce it consistently). I haven't been able to figure out what's causing it yet. Can you take a quick look at this and let me know if dragging in one direction works as we want? If yes, we can go over some of the ways I tried to get this to work in both directions and figure out the best way to get that working and some other small bugs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -18 lines) Patch
M chrome/browser/cocoa/bookmark_bar_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 3 chunks +41 lines, -16 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_view.mm View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_button.mm View 1 chunk +4 lines, -1 line 0 comments Download
Trybot results: Sign in to try more bots
Commit: CQ not working?

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be