Issue 2823993002: Issue 25558. Report an error, but don't crash when AST it too deep.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2823993002: Issue 25558. Report an error, but don't crash when AST it too deep. (Closed)

Created:
3 years, 8 months ago by scheglov

Modified:
3 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -44 lines)			Patch
M	pkg/analysis_server/analysis_server.iml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/error/error.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/error/syntactic_errors.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	6 chunks	+82 lines, -42 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Not sure of the value of this change given the impending move to front_end, but ...

3 years, 8 months ago (2017-04-17 21:16:39 UTC) #2

scheglov

3 years, 8 months ago (2017-04-17 21:47:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62320cc8388fd4f18dfd3125abcc6c47a652be82 (presubmit successful).