Disable Clear Browsing Data menu item in guest profiles

chrome/browser/ui/browser_command_controller.cc

Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 3f477f4d38f15a455fb64f0726366866be78c615..1e1d38a328efd55f2d0565e855354d4f54a831a7 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -798,7 +798,8 @@ void BrowserCommandController::InitCommandState() {
   command_updater_.UpdateCommandEnabled(IDC_RECENT_TABS_MENU,
                                         !guest_session &&
                                         !profile()->IsOffTheRecord());
-  command_updater_.UpdateCommandEnabled(IDC_CLEAR_BROWSING_DATA, normal_window);
+  command_updater_.UpdateCommandEnabled(IDC_CLEAR_BROWSING_DATA,
+                                        normal_window && !guest_session);

[Peter Kasting, 2017/04/18 01:58:13]

Seems like maybe the old |normal_window| check was wrong?  I'd think we just
want to check !guest_session here, as in the "show history" case above.

[tsergeant, 2017/04/18 03:10:36]

Yup, this makes sense: just checking !guest_session makes it possible to
Ctrl-Shift-Del to open CBD from a popup or app window, the same as how you can
Ctrl-H to open History.

Done.

 #if defined(OS_CHROMEOS)
   command_updater_.UpdateCommandEnabled(IDC_TAKE_SCREENSHOT, true);
   command_updater_.UpdateCommandEnabled(IDC_TOUCH_HUD_PROJECTION_TOGGLE, true);