Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2823953003: [ObjC ARC] Converts components/favicon/ios:ios to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/favicon/ios:ios to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2823953003 Cr-Commit-Position: refs/heads/master@{#465208} Committed: https://chromium.googlesource.com/chromium/src/+/7de4a87daad5ec01ffd65e353f47b5c3e7e44c11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/favicon/ios/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/favicon/ios/web_favicon_driver.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-18 09:34:10 UTC) #4
sdefresne
lgtm
3 years, 8 months ago (2017-04-18 12:34:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823953003/1
3 years, 8 months ago (2017-04-18 12:37:25 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 12:41:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7de4a87daad5ec01ffd65e353f47...

Powered by Google App Engine
This is Rietveld 408576698