Issue 282393002: Getting rid of raw pointers to SharedMemory in UserScriptMaster

Issue 282393002: Getting rid of raw pointers to SharedMemory in UserScriptMaster (Closed)

Created:
6 years, 7 months ago by manykey

Modified:
6 years, 7 months ago

Reviewers:
Jeffrey Yasskin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Getting rid of raw pointers to SharedMemory in UserScriptMaster BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271288

Patch Set 2 : reformat + assigning |handle.Pass()| instead of swapping #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
	M	chrome/browser/extensions/user_script_master.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/extensions/user_script_master.cc	View	1	8 chunks	+21 lines, -22 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jeffrey Yasskin

lgtm https://codereview.chromium.org/282393002/diff/1/chrome/browser/extensions/user_script_master.cc File chrome/browser/extensions/user_script_master.cc (right): https://codereview.chromium.org/282393002/diff/1/chrome/browser/extensions/user_script_master.cc#newcode341 chrome/browser/extensions/user_script_master.cc:341: base::Bind(&ScriptReloader::NotifyMaster, this, Generally use `git cl format` to ...

6 years, 7 months ago (2014-05-17 00:50:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/manykey@yandex-team.ru/282393002/20001

6 years, 7 months ago (2014-05-17 10:06:08 UTC) #5

Message was sent while issue was closed.

Change committed as 271288

Expand Messages | Collapse Messages