Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

Issue 2823883002: List Password Manager extensions in a static data structure (Closed)
Patch Set: removed dead comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/activity_services/activity_type_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
index 1721c8bb0a2396a5fd9828287d1e86f73adadaf9..9563e87825507b4d58448d7e7ae997081e6cdcdb 100644
--- a/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
+++ b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
@@ -187,7 +187,7 @@ class ActivityServiceControllerTest : public PlatformTest {
[activityController setShareToDelegateForTesting:(id)shareToDelegateMock];
// Sets up the returned item from a Password Management App Extension.
- NSString* activityType = activity_services::kAppExtensionLastPass;
+ NSString* activityType = @"com.lastpass.ilastpass.LastPassExt";
ShareTo::ShareResult result = ShareTo::ShareResult::SHARE_SUCCESS;
BOOL resetUI =
[activityController processItemsReturnedFromActivity:activityType
@@ -274,7 +274,7 @@ TEST_F(ActivityServiceControllerTest, ActivityItemsForDataWithPasswordAppEx) {
// Gets the list of NSExtensionItem objects returned by the array of
// id<UIActivityItemSource> objects returned by -activityItemsForData:.
NSArray* extensionItems = FindItemsForActivityType(
- items, activity_services::kAppExtensionOnePassword);
+ items, @"com.agilebits.onepassword-ios.extension");
ASSERT_EQ(1U, [extensionItems count]);
NSExtensionItem* item = extensionItems[0];
EXPECT_EQ(1U, item.attachments.count);
@@ -313,7 +313,7 @@ TEST_F(ActivityServiceControllerTest, ActivityItemsForDataWithPasswordAppEx) {
[OCMockObject niceMockForClass:[UIActivityViewController class]];
NSString* title = [actionSource
activityViewController:mockActivityViewController
- subjectForActivityType:activity_services::kAppExtensionOnePassword];
+ subjectForActivityType:@"com.agilebits.onepassword-ios.extension"];
EXPECT_NSEQ(@"kung fu fighting", title);
}
« no previous file with comments | « no previous file | ios/chrome/browser/ui/activity_services/activity_type_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698