Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 2823853005: ServiceWorker: Create a proxy when adding the worker to DevToolsManager (Closed)
Patch Set: Removed unnecessary nullptr Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 71ed5e6cd48d1c59f239c73b603756d82d509274..737417c88ce30130b965a300a4ade9502c079d02 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -50,6 +50,7 @@ class ServiceWorkerContextCore;
class CONTENT_EXPORT EmbeddedWorkerInstance
: NON_EXPORTED_BASE(public mojom::EmbeddedWorkerInstanceHost) {
public:
+ class DevToolsProxy;
typedef base::Callback<void(ServiceWorkerStatusCode)> StatusCallback;
// This enum is used in UMA histograms. Append-only.
@@ -191,7 +192,6 @@ class CONTENT_EXPORT EmbeddedWorkerInstance
private:
typedef base::ObserverList<Listener> ListenerList;
- class DevToolsProxy;
class StartTask;
class WorkerProcessHandle;
friend class EmbeddedWorkerRegistry;
@@ -210,9 +210,10 @@ class CONTENT_EXPORT EmbeddedWorkerInstance
// Called back from StartTask after the worker is registered to
// WorkerDevToolsManager.
- void OnRegisteredToDevToolsManager(bool is_new_process,
- int worker_devtools_agent_route_id,
- bool wait_for_debugger);
+ void OnRegisteredToDevToolsManager(
+ bool is_new_process,
+ std::unique_ptr<DevToolsProxy> devtools_proxy,
+ bool wait_for_debugger);
// Sends StartWorker message via Mojo.
ServiceWorkerStatusCode SendStartWorker(
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698