Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282373005: Mojo: Add a multiprocess platform handle passing test. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Add a multiprocess platform handle passing test. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271487

Patch Set 1 #

Patch Set 2 : remove extraneous whitespace #

Patch Set 3 : rebased #

Patch Set 4 : gah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -2 lines) Patch
M mojo/system/multiprocess_message_pipe_unittest.cc View 1 2 3 3 chunks +115 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-16 18:35:26 UTC) #1
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-16 19:37:47 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-16 21:01:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/282373005/20001
6 years, 7 months ago (2014-05-16 21:02:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 08:45:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 14:46:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/29525)
6 years, 7 months ago (2014-05-17 14:46:03 UTC) #7
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-19 16:22:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/282373005/20001
6 years, 7 months ago (2014-05-19 16:22:30 UTC) #9
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-19 18:28:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/282373005/60001
6 years, 7 months ago (2014-05-19 18:29:24 UTC) #11
viettrungluu
6 years, 7 months ago (2014-05-19 21:26:35 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 manually as r271487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698