Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: runtime/vm/clustered_snapshot.cc

Issue 2823633003: Allow the resolved names cache to be lazily created like the exported names cache. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/clustered_snapshot.cc
diff --git a/runtime/vm/clustered_snapshot.cc b/runtime/vm/clustered_snapshot.cc
index d57951938a1e4f10af0e618cdd004df720061119..3793d5d27df9b864c2d7aca8a0e13777d0005fc6 100644
--- a/runtime/vm/clustered_snapshot.cc
+++ b/runtime/vm/clustered_snapshot.cc
@@ -1460,21 +1460,6 @@ class LibraryDeserializationCluster : public DeserializationCluster {
lib->ptr()->is_in_fullsnapshot_ = true;
}
}
-
- void PostLoad(const Array& refs, Snapshot::Kind kind, Zone* zone) {
- // TODO(rmacnak): This is surprisingly slow, roughly 20% of deserialization
- // time for the JIT. Maybe make the lookups happy with a null?
-
- NOT_IN_PRODUCT(TimelineDurationScope tds(
- Thread::Current(), Timeline::GetIsolateStream(), "PostLoadLibrary"));
-
- Library& lib = Library::Handle(zone);
- for (intptr_t i = start_index_; i < stop_index_; i++) {
- lib ^= refs.At(i);
- const intptr_t kInitialNameCacheSize = 64;
- lib.InitResolvedNamesCache(kInitialNameCacheSize);
- }
- }
};
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698