Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8725)

Unified Diff: chrome/installer/util/work_item_list.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: add wow64 logic to installer_util. mini_installer tests. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/work_item_list.cc
diff --git a/chrome/installer/util/work_item_list.cc b/chrome/installer/util/work_item_list.cc
index fd00773675b5c987c84354f42656f5a3e9dc2cac..0550c8ad2799a7969b9ed122372c12295c4e7064 100644
--- a/chrome/installer/util/work_item_list.cc
+++ b/chrome/installer/util/work_item_list.cc
@@ -7,7 +7,6 @@
#include "base/files/file_path.h"
#include "base/logging.h"
#include "chrome/installer/util/callback_work_item.h"
-#include "chrome/installer/util/copy_reg_key_work_item.h"
#include "chrome/installer/util/copy_tree_work_item.h"
#include "chrome/installer/util/create_dir_work_item.h"
#include "chrome/installer/util/create_reg_key_work_item.h"
@@ -81,17 +80,6 @@ WorkItem* WorkItemList::AddCallbackWorkItem(
return item;
}
-WorkItem* WorkItemList::AddCopyRegKeyWorkItem(
- HKEY predefined_root,
- const std::wstring& source_key_path,
- const std::wstring& dest_key_path,
- CopyOverWriteOption overwrite_option) {
- WorkItem* item = WorkItem::CreateCopyRegKeyWorkItem(
- predefined_root, source_key_path, dest_key_path, overwrite_option);
- AddWorkItem(item);
- return item;
-}
-
WorkItem* WorkItemList::AddCopyTreeWorkItem(
const std::wstring& source_path,
const std::wstring& dest_path,
@@ -115,15 +103,19 @@ WorkItem* WorkItemList::AddCreateDirWorkItem(const base::FilePath& path) {
}
WorkItem* WorkItemList::AddCreateRegKeyWorkItem(HKEY predefined_root,
- const std::wstring& path) {
- WorkItem* item = WorkItem::CreateCreateRegKeyWorkItem(predefined_root, path);
+ const std::wstring& path,
+ REGSAM wow64_access) {
+ WorkItem* item =
+ WorkItem::CreateCreateRegKeyWorkItem(predefined_root, path, wow64_access);
AddWorkItem(item);
return item;
}
WorkItem* WorkItemList::AddDeleteRegKeyWorkItem(HKEY predefined_root,
- const std::wstring& path) {
- WorkItem* item = WorkItem::CreateDeleteRegKeyWorkItem(predefined_root, path);
+ const std::wstring& path,
+ REGSAM wow64_access) {
+ WorkItem* item =
+ WorkItem::CreateDeleteRegKeyWorkItem(predefined_root, path, wow64_access);
AddWorkItem(item);
return item;
}
@@ -131,9 +123,10 @@ WorkItem* WorkItemList::AddDeleteRegKeyWorkItem(HKEY predefined_root,
WorkItem* WorkItemList::AddDeleteRegValueWorkItem(
HKEY predefined_root,
const std::wstring& key_path,
- const std::wstring& value_name) {
- WorkItem* item = WorkItem::CreateDeleteRegValueWorkItem(predefined_root,
- key_path, value_name);
+ const std::wstring& value_name,
+ REGSAM wow64_access) {
+ WorkItem* item = WorkItem::CreateDeleteRegValueWorkItem(
+ predefined_root, key_path, value_name, wow64_access);
AddWorkItem(item);
return item;
}
@@ -166,17 +159,18 @@ WorkItem* WorkItemList::AddMoveTreeWorkItem(const std::wstring& source_path,
return item;
}
-WorkItem* WorkItemList::AddSetRegValueWorkItem(
- HKEY predefined_root,
- const std::wstring& key_path,
- const std::wstring& value_name,
- const std::wstring& value_data,
- bool overwrite) {
+WorkItem* WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
+ const std::wstring& key_path,
+ const std::wstring& value_name,
+ const std::wstring& value_data,
+ bool overwrite,
+ REGSAM wow64_access) {
WorkItem* item = WorkItem::CreateSetRegValueWorkItem(predefined_root,
key_path,
value_name,
value_data,
- overwrite);
+ overwrite,
+ wow64_access);
AddWorkItem(item);
return item;
}
@@ -185,12 +179,14 @@ WorkItem* WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
const std::wstring& key_path,
const std::wstring& value_name,
DWORD value_data,
- bool overwrite) {
+ bool overwrite,
+ REGSAM wow64_access) {
WorkItem* item = WorkItem::CreateSetRegValueWorkItem(predefined_root,
key_path,
value_name,
value_data,
- overwrite);
+ overwrite,
+ wow64_access);
AddWorkItem(item);
return item;
}
@@ -199,10 +195,15 @@ WorkItem* WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
const std::wstring& key_path,
const std::wstring& value_name,
int64 value_data,
- bool overwrite) {
+ bool overwrite,
+ REGSAM wow64_access) {
WorkItem* item = reinterpret_cast<WorkItem*>(
- WorkItem::CreateSetRegValueWorkItem(predefined_root, key_path, value_name,
- value_data, overwrite));
+ WorkItem::CreateSetRegValueWorkItem(predefined_root,
+ key_path,
+ value_name,
+ value_data,
+ overwrite,
+ wow64_access));
AddWorkItem(item);
return item;
}

Powered by Google App Engine
This is Rietveld 408576698