Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5016)

Unified Diff: chrome/installer/util/work_item.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: add wow64 logic to installer_util. mini_installer tests. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/work_item.cc
diff --git a/chrome/installer/util/work_item.cc b/chrome/installer/util/work_item.cc
index cab09ba623535fa0e56de4dd30bb3ed34d267e47..679606f90a84448f7a76a5e15957cde4613c9cf1 100644
--- a/chrome/installer/util/work_item.cc
+++ b/chrome/installer/util/work_item.cc
@@ -4,9 +4,10 @@
#include "chrome/installer/util/work_item.h"
+#include <windows.h>
+
#include "chrome/installer/util/callback_work_item.h"
#include "chrome/installer/util/conditional_work_item_list.h"
-#include "chrome/installer/util/copy_reg_key_work_item.h"
#include "chrome/installer/util/copy_tree_work_item.h"
#include "chrome/installer/util/create_dir_work_item.h"
#include "chrome/installer/util/create_reg_key_work_item.h"
@@ -29,15 +30,6 @@ CallbackWorkItem* WorkItem::CreateCallbackWorkItem(
return new CallbackWorkItem(callback);
}
-CopyRegKeyWorkItem* WorkItem::CreateCopyRegKeyWorkItem(
- HKEY predefined_root,
- const std::wstring& source_key_path,
- const std::wstring& dest_key_path,
- CopyOverWriteOption overwrite_option) {
- return new CopyRegKeyWorkItem(predefined_root, source_key_path,
- dest_key_path, overwrite_option);
-}
-
CopyTreeWorkItem* WorkItem::CreateCopyTreeWorkItem(
const base::FilePath& source_path,
const base::FilePath& dest_path,
@@ -54,20 +46,26 @@ CreateDirWorkItem* WorkItem::CreateCreateDirWorkItem(
}
CreateRegKeyWorkItem* WorkItem::CreateCreateRegKeyWorkItem(
- HKEY predefined_root, const std::wstring& path) {
- return new CreateRegKeyWorkItem(predefined_root, path);
+ HKEY predefined_root,
+ const std::wstring& path,
+ REGSAM wow64_access) {
+ return new CreateRegKeyWorkItem(predefined_root, path, wow64_access);
}
DeleteRegKeyWorkItem* WorkItem::CreateDeleteRegKeyWorkItem(
- HKEY predefined_root, const std::wstring& path) {
- return new DeleteRegKeyWorkItem(predefined_root, path);
+ HKEY predefined_root,
+ const std::wstring& path,
+ REGSAM wow64_access) {
+ return new DeleteRegKeyWorkItem(predefined_root, path, wow64_access);
}
DeleteRegValueWorkItem* WorkItem::CreateDeleteRegValueWorkItem(
HKEY predefined_root,
const std::wstring& key_path,
- const std::wstring& value_name) {
- return new DeleteRegValueWorkItem(predefined_root, key_path, value_name);
+ const std::wstring& value_name,
+ REGSAM wow64_access) {
+ return new DeleteRegValueWorkItem(
+ predefined_root, key_path, value_name, wow64_access);
}
DeleteTreeWorkItem* WorkItem::CreateDeleteTreeWorkItem(
@@ -93,9 +91,14 @@ SetRegValueWorkItem* WorkItem::CreateSetRegValueWorkItem(
const std::wstring& key_path,
const std::wstring& value_name,
const std::wstring& value_data,
- bool overwrite) {
- return new SetRegValueWorkItem(predefined_root, key_path,
- value_name, value_data, overwrite);
+ bool overwrite,
+ REGSAM wow64_access) {
+ return new SetRegValueWorkItem(predefined_root,
+ key_path,
+ value_name,
+ value_data,
+ overwrite,
+ wow64_access);
}
SetRegValueWorkItem* WorkItem::CreateSetRegValueWorkItem(
@@ -103,9 +106,14 @@ SetRegValueWorkItem* WorkItem::CreateSetRegValueWorkItem(
const std::wstring& key_path,
const std::wstring& value_name,
DWORD value_data,
- bool overwrite) {
- return new SetRegValueWorkItem(predefined_root, key_path,
- value_name, value_data, overwrite);
+ bool overwrite,
+ REGSAM wow64_access) {
+ return new SetRegValueWorkItem(predefined_root,
+ key_path,
+ value_name,
+ value_data,
+ overwrite,
+ wow64_access);
}
SetRegValueWorkItem* WorkItem::CreateSetRegValueWorkItem(
@@ -113,9 +121,14 @@ SetRegValueWorkItem* WorkItem::CreateSetRegValueWorkItem(
const std::wstring& key_path,
const std::wstring& value_name,
int64 value_data,
- bool overwrite) {
- return new SetRegValueWorkItem(predefined_root, key_path,
- value_name, value_data, overwrite);
+ bool overwrite,
+ REGSAM wow64_access) {
+ return new SetRegValueWorkItem(predefined_root,
+ key_path,
+ value_name,
+ value_data,
+ overwrite,
+ wow64_access);
}
SelfRegWorkItem* WorkItem::CreateSelfRegWorkItem(const std::wstring& dll_path,

Powered by Google App Engine
This is Rietveld 408576698